brynbodayle / babcropperview Goto Github PK

First of all, thanks for great library!

I found one issue with big screen iPhones.

Can be fixed with replacement of this line:

self.borderView.layer.cornerRadius = CGRectGetWidth(self.borderView.bounds)/2.0f;

to

self.borderView.layer.cornerRadius = CGRectGetWidth(displayCropRect)/2.0f;

Two Questions:

1. When image is loaded and if the image size is larger then the crop view size, I want to centre the image (currently the image scroll view is not auto scrolled to centre).

2. When image is loaded, I want the image scale to take up the entire phone Window (user can zoom in later if they want).

For question 2 I've tried to set "cropDisplayScale", "contentScaleFactor" & "scrollView.setZoomScale" but seems no luck.

In updateScrollViewZoomScales method:

else { //landscape image

if((scrollViewHeight >= scrollViewWidth) || (self.cropSize.width/self.cropSize.height < imageViewWidth/imageViewHeight)) {
.....
}

The OR operator is used in else condition instead of AND as defined in if condition.

ATM max zoom is set to 4 what results to image pixelation. Would be good to have an option to set limit for the maximal zoom to control cropped image oversizing.

I checked that there's no tag or release on GitHub, https://github.com/brynbodayle/BABCropperView/releases, and I think that's why pod install is falling because it can't find that tag while trying to clone the repo at that tag.

To fix it, I think you need to push your tags onto GitHub by running this in your terminal

git push --tags

Podfile:

pod 'BABCropperView', '~> 0.4.5'

Log:

> pod install
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Installing BABCropperView (0.4.5)

[!] Error installing BABCropperView
[!] /usr/local/bin/git clone https://github.com/brynbodayle/BABCropperView.git /var/folders/9x/zk40rlgn7sqc5rl6rl_qjs1h0000gn/T/d20160121-8474-1879es3 --single-branch --depth 1 --branch 0.4.5

Cloning into '/var/folders/9x/zk40rlgn7sqc5rl6rl_qjs1h0000gn/T/d20160121-8474-1879es3'...
warning: Could not find remote branch 0.4.5 to clone.
fatal: Remote branch 0.4.5 not found in upstream origin

My temporary workaround is to specify a commit in Podfile rather than a tag for BABCropperView.

pod 'BABCropperView', :git => 'https://github.com/brynbodayle/BABCropperView.git', :commit => 'af6c17a'

PS.

Great work! Thanks for your effort for making this lovely framework!

It would be really great if there was property to get CGRect of cropping rectangle, like 'UIImagePickerControllerCropRect' key in UIImagePickerControllerDelegate protocol:

Specifies the cropping rectangle that was applied to the original image.
The value for this key is an NSValue object containing a CGRect opaque type.

Or any suggestion how to get it would be appreciated. Great library btw, saved me a lot of time.

I'm losing a lot of the quality image using this code
Here are some before and after cropping

Thanks

Hello,

When you pinch zoom out an image to a smaller size, the image autoscales back up to fill the entire width. In this case, user needs a third hand to keep the image pinched while tapping the crop button. Is it possible externally to modify this behaviour?

Current behavior = image jumps back to match its width to crop area width

Proposed behaviour = image jumps back to fill width or height of the crop area, whichever is hit first. This way it would be easier for a user who for example wants to include the entire height of a portraid picture in a square

Is there an easy way to override this behaviour?

Hi! I trying to build project with your pod. My cocopod version is 1.0 beta 6

I've got this error:

error: /Users/alexey/Library/Developer/Xcode/DerivedData/Tipster-ghedtvicbrrnxbbbvlmlwydvyhet/Build/Products/Debug-iphonesimulator/BABCropperView/BABCropperView.bundle: No such file or directory

Can you delete bundle resources from podspec?

When i try to crop a transparent image, this library is not working properly. it is making background black. please check with this testing image.

Can I crop image by 200x200 but have whole resolution of image?
Example: I have image 4000x3000, show crop size 200x200 on screen and after crop I have 200x200. But real resolution 3000x3000. Can I get it?
Thanks!

Hi there, this lib is by far one of the best I found after a long time of surfing internet.

However there is a small detail when select small images using a particular crop size:

I'm using crop size 720 * 240 and I'm using this image:
http://www.thetechchat.com/wp-content/uploads/2012/08/Microsoft-Logo.jpg you can download it from safari on simulator.

when prompted to pick it displays the picture like this :

which is ok like that because the user might not want to scale it, and just when you tap crop... this happen

1. Is there a way to keep it centered and not aligned to the right?
2. Is there is a way to keep the background transparent? not black or at least white?

Cheers!.

Does this pod support swift 4.2?

Same as issue #11

It looks like for image I took from camera it doesn't work.

A not working image always not work (but if I use the iOS default editing tool do some edit and save, then it works).

Images from screenshot or from other sources always work.

Attached is a couple of not working samples FYI (same image works on Emulator but not on real device)

Hi

Control is really nice.

I am using crop with the custom scale size but sometimes cropped image returning nil.
Please let me know what could be the issue?

Thanks

I want to keep whole part of image.
Means no parts of image should be cropped.

if image is landscape image, then it should be converted into square image with black space on top and bottom

How to get the cropped image from the library.

Love the library! The issue board has been a great help and I am hoping to find an answer here :)

I am using this library to allow a user to crop an image into a 16:9 ratio image; however, when cropping, if the original image was portrait, there is excess space sometimes on the sides. When I crop, this space is then added to the photo. Is there a way that I can adjust the image size to include the proper cropping frame, but not the excess? I have been playing around with the values: x.allowsNegativeSpaceInCroppedImage and x.allowsNegativeSpaceInCroppedImage, however, they do not seem to work in this way.

Suggestions?

I'm Using BABCropperView (0.4.6). For some reason the photos I take with my device are falling into case UIImageOrientationRight thus being rotated by BAB Cropper

I don't fully understand what UIImageOrientation stands for and if this is expected.
I'd like to know if there is a way to disable the rotation of the image by the cropper or to correct (?) the orientation of my photo before cropping it

Thank you very much!

need change design cropping rect.
(like rounded, slash)

Hello,
i have noticed that last changes have broken the project.
When i run example project on iPhone 6+ (iOS 9.0) and choose taken photos (with imageOrientation == UIImageOrientationRight) - there is always the same result: cropped photo not rotated and not cropped actually.

It looks like the bug with small pictures, however the pictures are not so small..

For example I use default pictures from iOS simulator

Here is my code. The view is view of controller that is fullscreen size

babCropper.cropSize = CGSizeMake(view.bounds.width, view.bounds.width * 1.2)