brunyman / economybank Goto Github PK

Is it possible to give interest only to players which are not flagged AFK in essentials/essentialsX afk system?

Currently it works because it combines with Vault however, with BagOfGold, people can get away with lots of money in their bank by spamming the even number over and over such as if I have 10 BagOfGold in my hand and try to deposit, it's still in my hand but it still deposits 10 to the bank

Hi, I'm using 1.12.0 in Paper 1.13.2 and when I do /bank balance player an exception is thrown:

org.bukkit.command.CommandException: Unhandled exception executing command 'bank' in plugin MysqlEconomyBank v1.12.0
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[patched_1.13.2.jar:git-Paper-458]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[patched_1.13.2.jar:git-Paper-458]
        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:732) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1798) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1602) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:12) ~[patched_1.13.2.jar:git-Paper-458]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_181]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_181]
        at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:109) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1016) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:943) ~[patched_1.13.2.jar:git-Paper-458]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:841) ~[patched_1.13.2.jar:git-Paper-458]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
Caused by: java.lang.NullPointerException
        at net.craftersland.money.database.MoneyMysqlInterface.hasAccount(MoneyMysqlInterface.java:29) ~[?:?]
        at net.craftersland.money.ConfigHandler.printMessage(ConfigHandler.java:122) ~[?:?]
        at net.craftersland.money.commands.BalanceCmd.runAdminCmd(BalanceCmd.java:91) ~[?:?]
        at net.craftersland.money.CommandHandler.onCommand(CommandHandler.java:58) ~[?:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[patched_1.13.2.jar:git-Paper-458]
        ... 15 more

Paper 1.16.5
latest.log: https://pastebin.com/RGwFywV9

Bug:
/bank balance [OfflinePlayer]

Will show me their username as "pinkpig37772:" (my username is pinkpig3777).

As for an online player, I believe it always shows their nickname/name (which is good).

On my Server, interest doesn't get paid and the countdown with /bank balance doesn't reset when leaving the server. When it gets to 0 it stays like this for a few seconds and resets after it and starts all over again. But no chat message and no money on the bank account. There is also nothing in the logs about this. The plugin starts fine.

[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] Enabling MysqlEconomyBank v1.16.2
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] Using economy system: AConomy
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] Using permission system: PermissionsEx
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] Loading the config file...
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] MysqlEconomyBank loaded successfully!
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] Interest task started. Iterest will be given every 30 minutes.
[19:12:51] [Server thread/INFO]: [MysqlEconomyBank] MysqlEconomyBank has been successfully loaded!

Do you have any idea what is causing this?

Great plugin!
Would be awesome if players could list /bank baltop to view top bank balances.

Also would help staff better detect any red flags (I.e. money exploits).

Or if possible, combining /baltop from a vault supported economy plugin + the bank balance to list total player wealth baltop. Although that would be harder probably (if possible).

When we check through Console, it works perfectly. Offline nor Online players.
note that "AdamTest" is not connected.

input & output:

sent from Console:
`

bank Balance AdamTest
[09:10:49] [Server thread/INFO]: >> AdamTest balance: 0.0
`

sent from Ingame:
[09:10:55] [Server thread/INFO]: Adam issued server command: /bank balance AdamTest [09:10:55] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'bank' in plugin MysqlEconomyBank v1.15.1 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:48) ~[Paper.jar:git-Paper-655] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:151) ~[Paper.jar:git-Paper-655] at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:734) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1783) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1591) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:15) ~[Paper.jar:git-Paper-655] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:108) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1018) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:940) ~[Paper.jar:git-Paper-655] at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:837) ~[Paper.jar:git-Paper-655] at java.lang.Thread.run(Thread.java:834) [?:?] Caused by: java.lang.NullPointerException at net.craftersland.money.database.MoneyFlatFileInterface.hasAccount(MoneyFlatFileInterface.java:24) ~[?:?] at net.craftersland.money.ConfigHandler.printMessage(ConfigHandler.java:124) ~[?:?] at net.craftersland.money.commands.BalanceCmd.runAdminCmd(BalanceCmd.java:96) ~[?:?] at net.craftersland.money.CommandHandler.onCommand(CommandHandler.java:58) ~[?:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[Paper.jar:git-Paper-655] ... 15 more

Is it possible to edit the placeholder or add a new, so that the account balance is displayed without a comma? If I use the placeholder I get the following error message because of the comma: "The amount must be a positive number!"

Hello,
thank you for your great plugin.
How about an amount that can be set as an upper limit to stop the interest function?
This amount could be easily set in the config if you want or disable this feature with "false"

I would be very happy about an answer!

Best Tobi

There's the possible to set multiple interest percentages if I have more than 1 bank?

[10:35:53] [Server thread/INFO]: Der_Fuchs issued server command: /bank
[10:35:53] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Cannot execute command 'bank' in plugin MysqlEconomyBank v1.10.1 - plugin is disabled.
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:36) ~[spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchCommand(CraftServer.java:648) ~[spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.PlayerConnection.handleCommand(PlayerConnection.java:1397) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1232) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.PlayerConnectionUtils$1.run(SourceFile:13) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_161]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_161]
at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:46) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:748) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [spigot-1.12.2-R0.1-SNAPSHOT-b1600.jar:git-Spigot-4bd94dc-f4ca180]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]

I am the developer of the plugin Reserve, a modern economy API with modern economy features in mind. As I am now ready to publicly push the API, I'm currently looking for developers to add support for it.

Link: https://github.com/TheNewEconomy/Reserve

Advantages over Vault:

• Multi-currency support
• Async support using Java's completeable futures
• Optional Extended API to allow third party plugins to add new currencies

Current Plugins that support Reserve:

• Towny
• ChestShop3
• MineBay

Current Providers/Planned Providers:

• The New Economy
• Towny Eco
• GemsEconomy
• HellConomy

Thanks in advance,
creatorfromhell

Hello, i try to create a GUI for the bank, with a shop of bosshop what is opened for a NPC with CommandNPC addon, but the problem is i don't wan't to give my players the permission to use "MysqlEconomyBank.cmd.interest" and the others commands of the group .cmd. So in the plugin bossshop one of the options is to execute a command like OP when you buy something. In this way you do not have to give permissions to players to run for example a /time day command. And also the CommandNPC addon for Citizens has the option to when you add a command to a npc set the parameter "-o" which means that the command will be executed as OP, and therefore with all the permissions, but still using this combination. The plugin Economy Bank 1.10.1, tells my players that they do not have permissions, obviously I have tested it without having the permissions and it does not work. I would love you to add this to the plugin, since it makes it very interactive. If you like, I can make a small donation to encourage development. Thank you very much and greetings!.

The [Bank] sign doesnt works in warped, crimson wood signs

Struggling to figure out how to add permissions to other ranks, I have permissionsex and it works fine for anyone with OP but anyone who does not have OP it says BANK YOU DO NOT HAVE PERMISSION. Is there a file I'm supposed to edit to change the defaults for permissions? putting them into the rank permissions in permissionsex doesn't grant permission.

It would be nice to prevent chat message "Interest credited: $0.00" when the interest amount is null.
Thank you for this great plugin.

hey Economy Bank 1.16.1 didn't load, I use PhantomEconomy and Vault and other plugins there use economy work.

[20:03:05] [Server thread/INFO]: WEPIF: Vault detected! Using Vault for permissions
[20:03:11] [Server thread/INFO]: [MysqlEconomyBank] Enabling MysqlEconomyBank v1.16.1
[20:03:11] [Server thread/ERROR]: [MysqlEconomyBank] Warning! Vault installed? If yes Economy system installed?)
[20:03:11] [Server thread/INFO]: [MysqlEconomyBank] Disabling MysqlEconomyBank v1.16.1
[20:03:11] [Server thread/INFO]: [MysqlEconomyBank] MysqlEconomyBank is disabled!
[20:03:11] [Server thread/INFO]: [PhantomEconomy] Enabling PhantomEconomy v1.9.30-RELEASE

The people on my server can open up the shop, but they can't despoit or withdraw.
Perms are:
MysqlEconomyBank.cmd.deposit
MysqlEconomyBank.cmd.withdraw
bank.money
bank.open.chest
bank.open.entity
bank.open.sign

Issue:

• People can withdraw infinite amounts of money by initially withdrawing a negative amount.

Steps to reproduce:

• Deposit $1 to open account.
• Run command /bank withdraw -1000
• Observe bank balance is set to a high number and an infinite amount of money can be withdrawn.

Expected result:

• Run command /bank withdraw -1000 and the command fails and prevents further action.

• When you execute the command "/bank deposit amount" (or withdraw), if in quantity you do not put a number, spam the console with an error

You should do a check to see if it is a number or not

• Another error is that if you execute the command "bank balance name" you can not see the balance of the player, since he shows it to him

• Errors are also shown if you execute "bank balance name" and the user is not online