Giter Club home page Giter Club logo

prec's Issues

Test Meta properties from TinkerPop

if (propertyObject.meta !== undefined) {
let metaNode = DataFactory.blankNode();
this._addQuad(o, prec.hasMetaProperties, metaNode);
for (let metaKey in propertyObject.meta) {
let metaValue = propertyObject.meta[metaKey];
let propertyNode = propMaker[metaKey + tag];
this._labelize(propertyNode, metaKey);
this._addQuad(propertyNode, rdf.type, prec.PropertyKey);
this._addQuad(propertyNode, rdf.type, prec.CreatedPropertyKey);
this._addQuad(prec.CreatedPropertyKey, rdfs.subClassOf, prec.CreatedVocabulary);
let target = buildPropertyValue(metaValue);
this._addQuad(metaNode, propertyNode, target);
}
}

This snippet is never tested in a standard npm run test run, and probably buggy.

PREC-C: remove the notion of entity

The term entity is confusing and not really needed here.

Replace prec:edgeIs and prec:entityIs with prec:selfIs

  • Having two different predicates for basically the same thing is confusing
  • selfIs is more intuitive: "I'm removing pvar:self, what plays the role of pvar:self in my template graph ?"

Replace pvar:entity with pvar:holder

  • When using pvar:entity, the question of "which entity am I talking about?" rises
  • A property is on something, held by something

tinkerpop test doesn't pass

Because of the changes in the JSON alternate model, the tinkerpop tests doesn't pass anymore (mocha test\with_property_graph\tinkerpop.js)

Note that the node gremlin-to-rdf.js still produces the expected output.

rdf:subject as a propertyIRI

Corner cases that are not yet tested and are probably bugged:

Property Graph

[ ] -(s: "A Subject")-> [  ]

Context

[] a prec:PropertyModel ;
  prec:relationshipIRI rdf:subject ;
  prec:modelAs prec:DirectTriples .

prec:Relationships prec:modelAs prec:RDFStarUnique .

Expected result

:node1 :edge :node2 .
<< :node1 :edge :node2 >> rdf:subject "A Subject" .

Probable bugged result

:node1 :edge :node2 .
"A Subject" :edge :node2 

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.