brodybits / rollup-plugin-size-snapshot Goto Github PK

such as:

• 2.0.0
• 2.10.x
• 2.60.x

✅ done for Rollup 2.0.0 & 2.60.x in PR #5

I think it would be nice to find a way to test the dist build, in a similar fashion to how I added CI dist build testing to react-recompose.

Prettier does this in a much more elaborate way when building new releases.

(updated)

Updates wanted for more stable v.0.7.2 patch release to be made from patch-v0.7.x branch:

• switch from unsupported rollup-plugin-replace to @rollup/plugin-replace (as now proposed in PR #8)
• drop support for Rollup pre-0.68 (as now proposed in PR #8)
• update some other dependencies (as now proposed in PR #8)

prerequisite: #7 ✅

GENERAL RATIONALE:

• It would be ideal to switch away from outdated Rollup plugin, if possible in patch-v0.7.x branch:
• Considering that @rollup/plugin-replace is not officially supported with Rollup pre-1.0, it would be ideal to avoid the need for testing & support with older Rollup 0.x versions if possible

UPDATED PREREQUISITE(S):

• ensure that downstream react-recompose is upgraded to use Rollup 0.68 (as now proposed in react-recompose/react-recompose#25)

SOME IMPORTANT NOTES:

• removing support for Rollup pre-0.68 is a BREAKING CHANGE and assumes:
  • the recent v0.7.1-rc1 version of this fork is not to be considered "stable" (as now described in a commit message in PR #8)
  • downstream react-recompose is upgraded to use Rollup 0.68 (see TODO item above)
• switch to @rollup/plugin-replace with Rollup pre-1.0 results in an ugly installation warning message (tradeoff vs using unsupported Rollup plugin package, as described in a commit message)

general strategy for stable patch-v0.7.x release:

First release from patch-v0.7.x (v0.7.1-rc1) was not intended to be 100% stable, and it is now desired to drop Rollup pre-0.68 support as described above. Now that a version patch-v0.7.x is working with react-recompose, it is desired to make a more stable v0.7.x patch release with the changes described above.

Accidentally published v0.14.0 with missing dist contents, discovered that npm silently ignores publish script ref:

• https://docs.npmjs.com/cli/v9/using-npm/scripts#prepare-and-prepublish

Unfortunately npm does not let me unpublish this, deprecating it instead.

Published v0.14.1 with the dist contents included.

related:

• #24
• #26

I am now maintaining patch-v0.7.x branch to support react-recompose with Rollup 0.x, with some upcoming updates as discussed in issue #8.

Assuming that I can update react-recompose to use Rollup v2(+), with updates from main branch of this plugin, then I would like to drop support for Rollup 0.x from patch-v0.7.x branch.

I would like to support with both Rollup v2 & Rollup v3, as already proposed in PR #25 (in response to issue #24).

The hard part is adding GitHub CI testing with both Rollup v2 & v3, as the produce slightly different sizes as we can see in PR #25.

I think the best approach would be to define a special environmental variable in case of Rollup v2, in which case the tests would either expect different size results or expect some greater size variance.

/cc @geotrev

A couple issues were reported with handing errors from Terser:

• #17
• TrySound#61

A solution was proposed in issue #17, but I would need a reproduction in order to make a test case for this.

Any reproduction from the user community would be highly appreciated.

• add Node.js v20
• remove Node.js 19
• remove Node.js 14

Note: It may be interesting to see oldest Node.js version that this will work on.

related:

• #27

(updated)

While investigating #17 further I have discovered some issues if the code is blank or has only comments.

I added some tests in fd305a4. I discovered a case where it started reporting an internal error rather than "No content" from Webpack, introduced in commit 03f414a in patch release v0.13.3.

I have improved the error reporting in this case with a temporary workaround solution in 79a2ac5.

May need to investigate how Webpack would handle this kind of input in real life.

Some dependency updates will require minimum Node.js 14. This would be in a 0.x release.

UPDATED SCOPE:

• new minor release
• drop Node.js pre-14 support
• update dependencies
• future-proof Acorn parsing (PR #22) - deferred for now

Some dependencies should be updated to the most recent patch level if not release level before regenerating yarn.lock

Hello there!

Thanks for creating this package and maintaining it. I was wondering if there is any intent to adopt Rollup 3 support as a peer dependency in the near future?

Thanks!

Hi there, we've encountered a problem when the minified source does not output code. Found on this line here, the error from terser v4.8.0 is not handled, but rather we see an error where the length of the minified code has no length (found here).

[!] (plugin size-snapshot) TypeError: Cannot read properties of undefined (reading 'length')

Wondering if the solution below would be welcomed to throw this error (pseudo-code):

const { code: minified, error: minifiedError } = minify(source);

if (minifiedError) {
  throw minifiedError;
}

Happy to open up a pull request to patch.