Comments (7)
alisterburt
commented on July 30, 2024
Yeah this sounds good, did you have any specific examples in mind?
…On Thu, 19 Nov 2020 at 15:51, Lorenzo Gaifas ***@***.***> wrote:
I think that with out current idea of sub-Peepers, there would be quite a
bit of code duplication, or weird inheritance networks.
What do you think of having a few abstract classes with topic-specific
methods, and then our peepers could inherit from any combination of those,
while adding whatever connection is needed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#24>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXYBYHX2HZDVILGDMOCWS3SQUWHFANCNFSM4T3P6V2Q>
.
from blik.
brisvag
commented on July 30, 2024
For example, particle-related operations would be in one of these abstract classes. Then, a Peeper used for just particles can use them, as well as a RefinementPeeper that would also inherit from an image-related abstract class. this woudl allow the 2 peeper to reuse code, while having (for example) different constructor for easier creation.
from blik.
brisvag
commented on July 30, 2024
I'm not so sure anymore about this. The more I play around with the idea, and the more I get convinced that everything should be available in Peeper, so that if any data is added, no matter how you started you will be able to handle it.
We should probably set up a bit better the io_ module and have an all-encompassing read function (probably with modes) so that creating a peeper is seamless. this can probably be accessed by the peeper with an add_data() method, so that i can be used on init as well as later on.
As for everything else (displaying, analysis...), we should probably put everything in a generic peeper.
from blik.
alisterburt
commented on July 30, 2024
Gotcha, I think this can work and indeed may simplify things for eventual
users!
How about setting it up so that in its constructor the `Peeper` takes only
a list of `DataCrate`s
We could then implement any custom construction by factory methods such as
`from_relion_refinement_directory`, `from_relion_refinement_star_file` etc.
This gets verbose quickly, subpeepers could then just be `Peeper`s which
have a few modes for reading the necessary files etc, e.g. RefinementPeeper
knows during construction the things it could be looking for and constructs
from the correct `from_*` method?
…On Wed, 25 Nov 2020 at 10:27, Lorenzo Gaifas ***@***.***> wrote:
I'm not so sure anymore about this. The more I play around with the idea,
and the more I get convinced that everything should be available in Peeper,
so that if any data is added, no matter how you started you will be able to
handle it.
We should probably set up a bit better the io_ module and have an
all-encompassing read function (probably with modes) so that creating a
peeper is seamless. this can probably be accessed by the peeper with an
add_data() method, so that i can be used on init as well as later on.
As for everything else (displaying, analysis...), we should probably put
everything in a generic peeper.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXYBYBZSR7XKOAXDJ5QSEDSRTEYXANCNFSM4T3P6V2Q>
.
from blik.
brisvag
commented on July 30, 2024
I agree until the last point: I think it's strange and unintuitive that the object you're holding only differs in construction methods.
I would go with something like numpy's np.array(), which "alsways" spitsout a ndarray and it's only job is to guess from the input how to construct it.
from blik.
alisterburt
commented on July 30, 2024
hmm okay, I'm having a hard time seeing how we get everything to match up
when we try to infer everything from the data itself but it's a nice goal!
…On Wed, 25 Nov 2020 at 11:58, Lorenzo Gaifas ***@***.***> wrote:
I agree until the last point: I think it's strange and unintuitive that
the object you're holding only differs in construction methods.
I would go with something like numpy's np.array(), which "alsways"
spitsout a ndarray and it's only job is to guess from the input how to
construct it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXYBYBTPHODVCK7CN5DEALSRTPNDANCNFSM4T3P6V2Q>
.
from blik.
brisvag
commented on July 30, 2024
Obsolete/closed by #68 .
from blik.
Related Issues (20)
- Use dask HOT 5
- failed reading of star file HOT 1
- Images HOT 3
- Dependency issues HOT 2
- Failed to load mrc HOT 9
- saving files should add extension if needed
- saving star file does not save pixel size correctly HOT 1
- issue with star file reading? HOT 7
- reducing coordinate opacity makes black dots on the image layer HOT 12
- Generating the same particle twice overrides the existing layer but with broken orientations HOT 2
- Minor issue: expected MRC file extension HOT 1
- Suggestion: show tomograms in the same orientation as IMOD HOT 3
- out of slice fading of point and orientation layer HOT 2
- colouring points by data attribute HOT 4
- install error using Napari GUI HOT 7
- gaussian filter has no "Run" button HOT 2
- Convert meshblock to a multiblock HOT 1
- Clean up non-visualization code
- Import times are SLOW HOT 3
- Documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blik.