brightspaceui / button Goto Github PK

With the last round of focus style changes, text-decoration: none; was removed from the rule that was applied to :hover and :focus. This resulted in underline text decoration taking precedence in some scenarios.

Because we're importing the gradient.scss file without the extension, the new version of node-sass is complaining that it can't differentiate between that file and gradient.css.

d2l-button-icon currently forces the size of button icons to be .9rem (see #124)

We need bigger button-icons, but design wants to keep this limit in to maintain design consistency.

They don’t want this to use button-icon at all, in fact it actually supposed to be more like the icons in the main navbar within Brightspace (the course selector, notifications, gear, etc.).
This all falls under an “immersive nav” design pattern that the designers still aren’t sure about yet. So his recommendation (and I agree) is that we don’t standardize around a component just yet until they’ve had time to solidify the pattern.

According to Lockhart:

fix it at version 4 of icons for now, I’ll bring this up at our next designer checkpoint and escalate it.

First screenshot: P1
Second screenshot: P2

RTL styles incorrectly since v4.4.1 (#118) on Polymer 1.
v4.4.1+

v4.4.0

If an onclick event handler is wired up to the component (ex. d2l-button), it still gets run when the disabled attribute is present.