Giter Club home page Giter Club logo

Comments (3)

briancherne avatar briancherne commented on July 22, 2024

The comparison logic hasn't changed in the last six years. I just found something that worked and stuck with it. You're the first person to have looked at the guts close enough to care/comment.

Would there be any benefits when switching to Euclidean distance? Fewer false positives?!

The only caveat I can think of is that the default sensitivity might need to change, thus breaking anyone's custom override were they to upgrade without reading a disclaimer. I can live with that.

If there's a benefit, it certainly can be changed. If you have a mind for math and care to do it, I'll take a look at the pull request. I found your preliminary patch for ignoreScroll to be well commented. If it trades out one set of false positives for another, then we might leave well enough alone.

What do you think?

from jquery-hoverintent.

usmonster avatar usmonster commented on July 22, 2024

There will definitely be fewer false positives, especially for users that use trackpads, or high system-wide mouse sensitivity settings, and those who use very specific sensitivity and interval configuration options with hoverIntent.

As it stands, I can move the mouse perfectly diagonally a certain number of pixels, and that distance will generally be greater than the sum of the component movements in each dimension. This necessarily means that the fix will generate fewer false positives.

In simpler terms: the "bounding box" for the pointer's movement threshold in the current plugin is a diamond, and the fix would make it a circle.

I'm willing to submit a pull request with documentation (and an update to the default value).

from jquery-hoverintent.

usmonster avatar usmonster commented on July 22, 2024

:bump:

@briancherne, any interest in merging #14?

from jquery-hoverintent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.