Comments (7)
Is there any information about this issue? Was this functionality implemented?
from jquery-hoverintent.
Hi @louisameline and @dim2k2006! Thanks for the ping on this. This might be a good idea, though can you please let me know if unbinding events via $(selector).off('.hoverIntent')
would be a sufficient solution for your use case?
I'd just like some more discussion before deciding whether or not this is a common enough use case to include it in the upcoming milestone. :)
from jquery-hoverintent.
Hello, no, I need to apply my own namespaces. It feels wrong that you ask me to use your namespace anyway, it's precisely done for the user to customize his stuff. Jquery's event system is built exactly to handle libraries like hoverintent and you're missing features by not using it. I can't feel comfortable with this library if you don't handle events the way jquery does, this is a jquery plugin after all. And I really mean no offense but as a developer, I thought I'd let you know that the fact that this library misses that point doesn't make me confident about the author's skills and doesn't make me want to use it. I'm not saying that's a fact, I mean it's just the impression it gives. But that might just me. Thanks anyway for what you did so far.
from jquery-hoverintent.
Hi @louisameline! I'm sorry, but I actually took offense... which is usually what happens when you ask someone not to ;)
You should be confident in the author's and maintainer's skills, and the quality of the code, when a plugin (never part of the core library) is still compatible and actively in-use 10 YEARS after it was created... and the only open issues are of the feature-request variety.
We've made changes to modernize hoverIntent before. Per this issue (#55) I'm not opposed to extending how hoverIntent is applied to elements so long as it can be done without breaking existing implementations. Someone just needs to write the pull request.
from jquery-hoverintent.
Hello, I apologize for hurting your feelings.
It's a good thing that this library works after 10 years, kudos for that :) What I tried to say, with the wrong words, is that IMHO it would need a fresh paint coat to meet the API quality I expect from a modern plugin.
As for breaking existing implementations, that's what major versions are for in semver, I see no issue here. The current API is unpractical and will be redundant with jQuery's event system, so it should be removed from a v2.
As a side note, the unbinding thing is real issue though, it leads to memory leaks. I was initially discouraged to make a PR as I was not sure if this project was still maintained. It seems that a v1.9 by @usmonster has been in the works for a long time, but his fork has many branches, maybe he could clarify where we can find the latest project files? It would be nice if there was a dev branch here on this project instead.
Thanks.
from jquery-hoverintent.
Hi @louisameline!
It seems that a v1.9 by @usmonster has been in the works for a long time, but his fork has many branches, maybe he could clarify where we can find the latest project files?
To address your question/misunderstandings:
- v1.9 (not yet released) is the
master
branch of this repository. Other versions are tagged. - My personal fork's branches are meaningless for you, as the repo description says. ;)
- Yes, the milestone has 3 "easy" non-dev tasks left, which haven't been done for a while. My bad! In any case, the master branch is functionally equivalent to what will eventually be v1.9 and is safe to use in production.
As for the change you propose, I agree with your reasoning to use the "jQuery way" of event handling, especially in preference over #43. Still, you shouldn't be surprised that we'd of course want to discuss your specific use case to see if there's general enough need, to make sure the problem (memory leak) exists on the current version, and only then decide if & how to prioritize it.
All that said, I think a PR would be welcome for this, if you're willing to make one. If not for v1.9, I can see this in a v2.0, if @briancherne agrees.
from jquery-hoverintent.
Ok, thank you for your explanations.
from jquery-hoverintent.
Related Issues (20)
- create gh-pages branch, change official site to github.io HOT 7
- Check over/out methods gracefully. HOT 5
- make new version HOT 1
- Add an minified version HOT 1
- Late firing on mobiles HOT 7
- Timeout only applys to mouseout method and doesn't affect mouseenter HOT 4
- Is it work with dynamically added element? HOT 3
- cdnjs issue was opened HOT 1
- remove bower.json
- 1.8.1 on NPM is a mismatch? HOT 7
- Disabled button not firing "over" (in a very specific circumstance) HOT 2
- handlerOut not triggered when domElement is removed dynamically HOT 3
- Improperly triggers mouseout when hovering a child inputs auto complete suggestion. HOT 3
- Possible bug HOT 3
- Deprecated jQuery HOT 1
- how to import like/in es6 modules? HOT 1
- ES6 version
- Typescript types needed HOT 1
- Failed to open stream HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-hoverintent.