brgmnn / fish-docker-compose Goto Github PK

The main docker-compose repo has a minimal set of completions that only contains some optional -- style arguments on the main docker-compose command. Those don't seem to be in this repo. Could those be added?

Describe the problem

If I type

docker-compose run test mylibrary/<tab>

...where test is a service and mylibrary is a path (relative to the current path), I don't get any completions for the path. Without fish-docker-compose, I do get completions.

While in some compose configurations it's correct to disallow that, in the (I think fairly common?) case that the current path is mapped as a volume into the container, it's valid.

And my prior is that it's better to allow too much than disallow too much

How would you feel about deferring to the existing completions in the case that fish-docker-compose doesn't a valid completion?

Software versions

Fish Shell version: fish, version 2.7.1
Docker Compose version: docker-compose version 1.18.0, build 8dd22a9
Compose file version: 2.2

Hello, I touch you because I want to know if it is possible to adapt on debian. I want to use for fish-docker made without success.
Thank you.
Have a good day

When I'm hitting tab I'm getting the following result:

Describe the problem

Autocomplete on service name produces the following error:

~/.config/fish/completions/docker-compose.fish (line 5): switch: Expected exactly one argument, got 2

    switch $file_version
           ^
in function '__fish_docker_compose_all_services'
	called on standard input

in command substitution
	called on standard input

Software versions

Fish Shell version: 2.6.0
Docker Compose version: 1.16.1
Compose file version: 2.1

Describe the problem

They way the parsing for services/version is done currently seems a bit problematic. Docker compose has built-in introspection via docker-compose config [--services] so you can use the output of that to get the version or list of services.

This should also make it possible to get it to work with multiple docker compose files (via -f flag) as the output of that command is the "merged" list.

My fish-fu is quite weak but if you have some questions on docker I'm happy to answer those.

Docker Compose 1.6 introduced new file format and added a new command docker-compose events.[1] That unfortunately means that service name suggestion won't work properly with new docker-compose.yml.

Version 1.7.0 added several new flags and commands:

• the -f flag for docker-compose logs
• the --remove-orphans flag for docker-compose up and docker-compose down
• the --all flag for docker-compose rm
• the same TLS configuration flags used by the docker client (--tls, --tlscert, --tlskey, etc.)
• the --workdir flag for docker-compose run
• the --follow, --timestamp, and --tail flags for docker-compose logs
• the --build flag for docker-compose up
• the docker-compose exec command

I'm using fisher as package manager for my fish and get:

fisher install brgmnn/fish-docker-compose
Installing plugin/s
      docker-compose
No command 'fundle' found, did you mean:
 Command 'bundle' from package 'bundler' (universe)
fundle: command not found
~/.config/fisherman/conf.d/docker-compose.init.fish (line 1): fundle plugin 'tuvistavie/fish-completion-helpers'
                                                              ^
from sourcing file ~/.config/fisherman/conf.d/docker-compose.init.fish
        called on line 2 of file ~/.local/share/fisherman/functions/__fisher_plugin_source.fish

in function “__fisher_plugin_source”
        called on line 33 of file ~/.local/share/fisherman/functions/__fisher_plugin_enable.fish
        with parameter list “docker-compose /home/elopez/.config/fisherman/conf.d/docker-compose.init.fish”

in function “__fisher_plugin_enable”
        called on line 48 of file ~/.local/share/fisherman/functions/fisher_install.fish
        with parameter list “docker-compose /home/elopez/.config/fisherman/cache/docker-compose”

in function “fisher_install”
        called on line 1 of file -
        with parameter list “brgmnn/fish-docker-compose”

from sourcing file -
        called on line 60 of file /usr/share/fish/functions/eval.fish

in function “eval”
        called on line 51 of file ~/.local/share/fisherman/functions/fisher.fish

in function “fisher”
        called on standard input
        with parameter list “install brgmnn/fish-docker-compose”

1 plugin/s installed (4s)

Fish shell comes with completions so I suggest to move the completions to the fish shell repository. I will make a pull request with your completions to fish-shell. Feel free to comment here fish-shell/fish-shell#4731.