brescia123 / forms Goto Github PK

Remove FormPresenter and add FormRecyclerView

Update code also

• Add error: String? to SectionViewModel.
• Introduce a configuration also for SectionModel (as for FieldModel) that contains the title (previously a field of SectionModel) and the rules (use FieldRulesValidator interface modified to be general and not field specific).
• Modify hasErrors() logic from FormModel to take into account also section errors.

Hi Giacomo,
This library would be really useful to anyone frequently developing forms on Android. Is it possible to add an open source licence to use the forms library ?
Thanks,
Abhi

Make the various logI, logE... extension functions private to the library.

• Simplify declaration and internal structure
• Change name to NodeRepresentation

Simply change hidden to visible and adjust usages.

The FormModel should decide on its own where to subscribe and observe Singles and Observables, and should use schedulers passed as dependency.

Currently to define a form the syntax is the following:

FormModel.form(storage, formActions) {
    page("Page Title") {
        section("Section Title") {
            field(key = fieldKey,
                    serialization = fieldSerialization
                    config = fieldConfiguration
        }
    }
}

Improve it to be something like:

FormModel.form(storage, formActions) {
    page("Page Title") {
        section("Section Title") {
            field("Field Label") {
            	configuration { fieldConfiguration }
                serialization { fieldSerialization }
            }
        }   
    }
}

Write a lint rule that warns the user if he is defining more than one configuration or serialization for a field within the Form DSL.

field("key") {
    picker("label") {
        ...
    }
    checkbox("label") { // Should show a warning
        ...
    }   
    serialization {
        ...
    }
    serialization { // Should show a warning
        ...
    }

The warning should make it clear that the first defined configuration/serialization will be overwritten by the second one.

Start using jsonnode