Getting this error whenever the extension loads now.

This commit has a good example: 9a4cc47

On the discussion page, move the close-and-comment button away from the comment button. They are too close together and often result in accidentally closing the pull request.

Today I noticed that diff collapsing stops working. I checked localStorage and found something like ppr|my|repo|#201|undefined, it seems the extension can't get the correct diff-id. The extension works just fine for me before, maybe caused by some updates of GitHub?

First of all, I love this extension, it's a life saver for me for reviewing large pull requests and not lose my focus.

One last feature i'd like to see is to be able to add "in progress" comments. The use case is that for very large pull requests i sometimes have an idea that something needs to be changed but i can't articulate it fully yet. (e.g. "eww this is gonna mess up the code base we need to find a way to make this scale better"). only once i've looked through the full PR or even thought more about it i am able to write a public comment that is productive instead of just negative.

Optimally the way it works is something like this:

• i can click next to any line and a new comment icon pops up
• clicking opens textbox (i don't think markdown or preview is required, just nice to have)
• submitting stores the comment in local datastore (browser specific), this seems like the easiest solution (cross browser support with server side storage would obviously be nice, but seems like total overkill)
• comment display inline similar to official public github comments, but formatted slightly differently to signal it's internal only for now
• next time i open the diff the comments get displayed automatically like you'd expect

curious if you think that's a possibility. keep up the great work!

So we could close and reopen the tab and the files would still be collapsed.

Right now when you mouse over the name of a diff it is the text selection pointer, which doesn't give you the sense you can click on it. If this was changed to a pointer, the benefits would be two-fold:

1. Obvious feedback that, "Hey, I can click on this", and
2. You would know for sure that you had installed the extension

Should be an easy css change!

It would be cool to just be able to hit the Tilde key and have it flip through each of the tabs on a pull request. An example of this is how you can go command-` to flip through windows in an app on OS X.

After a PR is loaded, pressing would take you to the Commits tab. Pressing it again would take you to Files. Pressing it a third time would take you back to the first page, Conversation. I should be able to keep hitting to cycle through all of the tabs.

I don't know how easy this is. But it would be pretty awesome.

Add a checkbox somewhere (page action?) to allow the file diffs to occupy that entire browser's width.

This commit has good examples: 9a4cc47

Currently people just have to Google for the extension if they want to use it after finding it on GitHub. Or they have to manually run it, I guess. But it'd be cool to be able to just share them this repo link so that they can contribute if they want, but they could then also get right to the download page from here. Which is this:

https://chrome.google.com/webstore/detail/pretty-pull-requests-gith/ljnjpkadhhcdniohpfilddnhahoigdec?hl=en

I'd do it, but I don't have permissions to do so.

As you can see.

In my organization, we have many very large pull requests that we do formal code review meetings on.

I would like the ability to define categories in the scope of a single PR and add files to these categories. A list (tree?) of these categories could be displayed on the lefthand side of the page. I would like to then add changed files (or even specific hunks) to a category. In this way, I would be able to prepare for a code review meeting by creating categories like 'core changes', 'necessary refactors', 'tests', 'changes that need a group decision', etc. And organize my categories in the order they will be presented at the meeting.

I have not yet seen any chrome extension that allow for this kind of thing. Any suggestions to alternative ways of solving this problem would also be welcome.

Add checkboxes to collapse/expand the lines removed or lines added from a file diff.

In the tree view, you can use the arrow keys to go through the list of folders. However, when you press right, unfolding a folder, the highlight is removed. When you press right again, it correctly goes to the first item in the unfolded folder. This is the correct behaviour, but the highlight that disappears is counterintuitive.

Some times you need an explanation as to why that line of code was changed and the explanation is in the commit message but switching from one view to the other to find the exact commit that diff relates to just to read what the commit message was sucks... Almost like a blame type feature on the PR but including the message.

If a user goes to a pull request via its "home" page (usually the discussion), the content script is not injected when the user switches to the file view. It appears github does not do a page reload, just updates the URL and loads the files via ajax.

Need to inject the content script on any page matching the pull request URL pattern, not just the files page.

First of all, great plugin!

This worked well for me for a couple weeks and now I'm unable to get the js to load on GH enterprise pages. It works as expected on non-GHE pages.

I've disabled all other plugins and I still can't get GHE PR files to toggle. When I use the dev tools inspector I can see that the plugin never loads its js/css. However, regular GH pages load the js/css correctly.

I get prompted for new permissions when I enter the GHE url in the options, but I see no change in functionality. I'm wondering if other GHE users have experienced recent degradation.

Thanks for any help. This plugin helps very well w/ managing PRs.

Seems that with GH's new menu-based file selector in PRs, this plugin no longer works...

Allow a diff to be collapsed from the bottom. This accommodates workflows that involve reading a file then collapsing it to remember that it is already done.

GitHub Enterprise installations usually have a different URL than public GitHub, so the current configuration of URLs to apply the plugin to don't work.

Please allow configuring the URL to apply to or make available as a UserScript so that we can use this with Gitub Enterprise (ie. non-GitHub URLs)

Add a tree view somewhere (page action perhaps?) that gives a list of the files in the diff, as well as making them links directly to the file.

I think most people (certainly @Yatser ) know of this bug, but just making it to make it official and to make it known I plan to work on this.

Reproduction:

1. Open a pull request
2. Collapse a diff for a file
3. Make another pull request
4. See that the diff for that file is still collapsed, even though it's a new pull request

My current thought is to make the key somewhat more specific than it is now. Currently we're just storing a diff id which you'd think would be enough, but it seems to be the same diff id between PRs. Perhaps storing a concatenation of projectName + '|' + pullRequestNumber + '|' + diffId, which dang well better be unique enough.

If I'm looking at the list of pull requests, a /pulls URI, and I click on one, none of the collapse stuff shows up. One has to refresh the page when you're on the PR to make that stuff show up.

This is because the transition to the PR happens via PJAX, so we probably need to add a listener for that or something.

@yatser I'd love to work on this, and I'm working on something else for this project right now, but in my own fork. Wanna give me full permissions and I can branch off your repo?

The following bookmarklet code can be used to automatically unfold folded code:

javascript:(function() {
    var interval = setInterval(
        function() {
            var expand = document.getElementsByClassName("diff-expander");
            if (expand.length == 0) {
                console.log('Done expanding');
                clearInterval(interval);
            } else {
                console.log('Expanding ' + expand.length);
                for (i = 0; i < expand.length; ++i) {
                    expand[i].click()
                }
            }
        }
        , 1000);
}());

What do you think about adding this featur as an action in this extension?

Github has (very nicely) asked me to change the logos of this extension, since I am in violation of their logo policies here https://github.com/logos. Need to come up with a new logo/icon that makes sense for this extension while not being recognizable as an official github product.

Example of something I can't collapse: