brentstineman / buttonpong Goto Github PK

Hi!

I'm seeing a mismatch in code between the firmware and the API for triggering a winner. (See #18 for my first stab at this issue).

The firmware is expecting a timeout value of "-1" to be sent to trigger the "game won" state. See:
https://github.com/brentstineman/ButtonPong/blob/master/firmware/src/buttonpong.ino#L160-L166

The API is invoking a "winner" wekhook which is expecting a function called "winner" existing in the firmware. See:
https://github.com/brentstineman/ButtonPong/blob/master/api/csharp/CloudAPI/PingManager.cs#L83-L88 and
https://github.com/brentstineman/ButtonPong/blob/master/api/csharp/CloudAPI/Infrastructure/ParticleDeviceCommunicator.cs#L84-L87

Either the API needs to be updated to not call the "winner" webhook and use the "-1" timeout instead or the firmware needs to be updated to only trigger a winner event in a new function called "winner" (like #18 but also removing the code in the ping function.

Thoughts?? I'd be more than happy to change the code and submit a pull request once the proper "winner" triggering method is determined. I think adding a "winner" function to the firmware is the more ideal approach since it's more clear.

Thanks!
Mikael

Implement a NodeJS version of the API to allow for non-.NET developers to easily work with the API code. Should exist side by side with the .NET API version.

All attempts to call the device API from the Function API are fire and forget. These need to be made more resilient.

Revamp .Net API to allow deployment via command line or a linked repo by removing requirement that it has to be complied and deployed via Visual Studio. Need to maintain support for local testing, perferrably via Visual Studio.

Add instructions to the repository for running hack events. Be sure to include:

• key calls-outs from the previously used PPT
• adding a stock powerpoint for use during hacks
• coach/proctor notes
• suggestions for division of labor within the team
• call out items for the less technical participants

Enhance the game reset API so that it will send a reset signal to the buttons to reset their internal game state. This also requires adding a new function to the device to accept such a call.

Fix threading issues with in the Start Game API.