brendantwh / pe Goto Github PK

Assignment is misspelt under grade command

Telegram handles usually contain something after @ but commands like add and edit accept h/@.

For the command: edit 10 h/@, the 10th student is edited to have "Telegram: @"

For the command add n/d m/ddd1234 id/ddd h/@, the same problem occurs

Expected behavior: Reject just @ input and check for valid Telegram handle after @ character

Both add and edit check for module input constraints (as stated in UG), but filter m/ does not do the same check.

For the commands:

• filter m/Abcdefghijklmnop
• filter m/;;;;
• filter m/""""
• filter m/9

They are not of the convention stated in UG: which is letters, 4 digits, then optional letter suffix, but filter still allows them through. This is what is shown after any of the above commands are run:

Expected behavior: Run the same check on filter m/ as the add and edit command so users know the problem with their command

GitHub usernames do not allow for spaces (cannot exactly remember but this should be true) but g/d d d is allowed for add and edit

For the command edit 11 g/d d d, the student's GitHub username is successfully updated to d d d

Expected behavior: Reject GitHub usernames which have spaces in them, check for characters allowed/disallowed in GitHub username

Under tag command in the UG, example 2 tag all t/goodstudent t/potentialTA claims to add tags goodStudent and potentialTA as tags.

Expected: Command should either add goodstudent, or the command should be changed to tag all t/goodStudent t/potentialTA to achieve the stated outcome.

Dummy bug report

Picture here:

Implementation of filter refers to filterPersonListWithPredicate method in Model/ModelManager. However Model (and therefore ModelManager) only has filterStudentListWithPredicate and no filterPersonListWithPredicate as stated in DG:

and