breenie / silex-doctrine-migrations-provider Goto Github PK

I have been working on Doctrine Migrations 2.0 in https://github.com/doctrine/migrations master.

Opening an issue here to discuss and track progress for upgrading this library to 2.0.

Autoloading could be changed from PSR-0 to PSR-4. That would keep the same namespaces, but would reduce the nested folders.

@breenie What do you think of supporting Pimple-only installation when Silex is not present? I think this is the recommended way as it's more portable and could be used in projects using Doctrine and Pimple without using Silex. That's why the service provider was moved from Silex to Pimple and also why Silex now publish their providers as a separate Composer package.

This means not using the BootableProviderInterface. We could move everything to register() and make things more lazy. Getting the configuration object would be lazy through Pimple. The only obstacle is adding the commands - if we add them in the register method then the configuration would be retrieved from the container before any option overriding from the user has been applied. So we could still add the commands in the boot method, but if you are not using Silex you'd just need to add the commands yourself or even better - call the boot method on the provider yourself and it'd add the commands for you.

How do you feel about that? Do you want me to make a PR with the described suggestions so we could discuss a concrete implementation?

Hi all,

I am not totally sure that your tool is what I am looking for.

Can I generate the migration diff from the current database state? If yes, how should I proceed?

Thanks for your help.
Timothée

Could you clarify which branch should be used to base pull requests against? I see you are merging things to the develop branch, but the default branch of the repo is master.

Personally I don't see why you'd need both branches in a small repository such as this. For me the GitHub flow of merging into master and tagging releases from there is working fine.

Anyway, using the develop branch or not is up to you, but a clarification of what to base PRs against would be very welcome. Probably in CONTRIBUTING.md.

Thanks!

I installed dev-develop via composer and when I open the doctrine migrations-provider I get the message that Symfony\Component\Console\Helper\DialogHelper can not be found.

Best,
Florian

This service provider supports only Silex 1.x. It would be great if it's migrated to support Silex 2.x with the new structure of service providers.