The devDependency lerna was updated from 3.4.1 to 3.4.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lerna is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

As it stands right now, any Android app with a minimum SDK version set >= 21 will be unable to be uploaded to the Google Play store due to how the versionCode is crafted:

1. The version is first normalized:

   flagship/packages/flagship/src/lib/android.ts

   Lines 123 to 127 in 2df9d15

   	fs.update(
   	path.android.gradlePropertiesPath(),
   	/VERSION_CODE_SHORT=\d+/,
   	`VERSION_CODE_SHORT=${versionLib.normalize(newVersion)}`
   	);

   which converts a version to XX.YYY.ZZZ format by inserting zeros where appropriate:

   flagship/packages/flagship/src/lib/version.ts

   Lines 19 to 33 in 2df9d15

   	/**
   	* Normalizes a version number into a standard format XX.YYY.ZZZ
   	*
   	* @param {string} version The version number to normalize.
   	* @returns {string} A normalized version number.
   	*/
   	export function normalize(version: string): string {
   	const versionAndLabel = version.split('-');
   	const parts = versionAndLabel[0].split('.');
   	return [
   	padZeros(parts[0], 2),
   	padZeros(parts[1], 3),
   	padZeros(parts[2], 3)
   	].join('');

2. The minimum SDK version is then appended to the front of the normalized version string:
   

   flagship/packages/flagship/android/app/build.gradle

   Line 110 in 2df9d15

   versionCode "${rootProject.ext.minSdkVersion}${project.VERSION_CODE_SHORT}".toInteger()

Using an example version of 1.2.3 with a minSdkVersion=21, the resulting versionCode would be 2101002003, however the maximum value Google Play allows for versionCode is 2100000000. When attempting to upload any app with a versionCode > 2100000000, you are presented with the following error:

The version code of your APK or Android App Bundle is high and you risk not being able to update your APK or Android App Bundle.

There are a few possible ways to fix this issue:

1. Adjust the normalize function to only insert zeros to a max length of 2 rather than 3 (e.g. resulting format would be XX.YY.ZZ rather than XX.YYY.ZZZ)
   • This change would affect both Android and iOS builds
2. Adjust the Android versionCode definition to remove the minSdkVersion from the front of the versionCode

NB
This fix WILL be a breaking fix, as new version codes will be less than the currently uploaded ones. Any Android application built through Flagship and uploaded to Google Play would need to have some sort of patch in place in its individual code base to account for this change.

In ReviewDetails:
https://github.com/brandingbrand/flagship/blob/b6ba811acea1db8b5b2da201fcbc3b45f6062106/packages/fscommerce/src/Review/types/ReviewDetails.ts
summary is completely redundant to statistics, because statistics extends summary and all of its new keys are optional. This can cause confusion because a user won't know whether to put something into summary or statistics.

Currently the Android project path is hardcoded to be "com.brandingbrand.reactnative.and.project_name" as specified in getNativeProjectPathAndriod [sic]:

This value is used in a few places during Android init, such as constructing applicationId in build.gradle.

This is an issue for a couple of reasons:

1. Because Flagship is now open source, application identifiers shouldn't be required to have "brandingbrand" in them
2. We let apps define arbitrary bundle IDs in the bundleIds.android environment configuration, so it isn't obvious that the bundle ID actually needs to conform to a strict schema that consists of "com.brandingbrand.reactnative.and." followed by the name property in the environment configuration

Version 1.9.0 of react-native-masked-text was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-masked-text is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 0.8.9 of babel-plugin-react-native-web was just published.

This version is covered by your current version range and after updating it in your project the build failed.

babel-plugin-react-native-web is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 4.16.0 of webpack was just published.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 5.2.3 of react-native-sensitive-info was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-sensitive-info is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

yarn add [email protected]

yarn add react-native-sensitive-info@beta

Your Greenkeeper Bot 🌴

I have the code in another project and I plan to port it over to the fsshopify package.

i need them!

Happens when the product item heights differ (eg. product name wrapping, only some products having reviews, etc).

Version 6.5.1 of react-native-svg was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-svg is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency @types/react-dom was updated from 16.0.7 to 16.0.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react-dom is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency npm-run-all was updated from 4.1.3 to 4.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

npm-run-all is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Flagship should be updated to use React-Native-Navigation v2 and an abstraction layer/implementation should be created for web.

The devDependency @commitlint/travis-cli was updated from 7.1.2 to 7.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@commitlint/travis-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Currently shows after the last element on the page, so it's annoying to access on pages with a lot of content.

The devDependency @types/react-native-push-notification was updated from 3.0.2 to 3.0.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react-native-push-notification is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rimraf was updated from 2.6.2 to 2.6.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rimraf is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Add a prop to set the position of the 1/2 screen modal component (top, bottom[default], center).

This will allow the component to have more use cases.

Basically a non-working button with text for step markers ('1', '2', '3', etc.), any other UI elements that look like buttons but aren't clickable.

When developing an app with Flagship for multiple brands that utilize the same overall structure but differ in some way for each specific brand, it would be handy to be able to initialize the app with brand parameters.

Possible implementation:
Add functions in the init.ts command in the flagship module that would look for brand.brandName.js files in the project env (or new brand) folder that would combine this information with the environment information for the final env.js file.

The devDependency @commitlint/cli was updated from 7.1.2 to 7.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@commitlint/cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency react-native-web was updated from 0.8.10 to 0.8.11.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-web is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

the padding prop is supposed to be passed to state & then implemented as left, right & bottom padding, but it is not being passed and instead the padding is always set to the default 15 pixels.

Version 1.1.477 of react-native-navigation was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-navigation is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 3.1.0 of webpack-cli was just published.

This version is covered by your current version range and after updating it in your project the build failed.

webpack-cli is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 2.88.0 of request was just published.

This version is covered by your current version range and after updating it in your project the build failed.

request is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency @types/jest was updated from 23.3.2 to 23.3.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Steps:

• Add dependencies in a project
  • [email protected]
  • [email protected]
• yarn in project
• yarn run init the project
• build Android

FAILURE: Build failed with an exception.
* What went wrong:
Failed to capture snapshot of input files for task ':react-native-maps:compileReleaseAidl' property 'importDirs' during up-to-date check.
> The library com.google.android.gms:play-services-basement is being requested by various other libraries at [[15.0.1,15.0.1]], but resolves to 10.2.4. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.

Version 4.17.1 of @types/lodash-es was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/lodash-es is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 1.6.7 of react-id-swiper was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-id-swiper is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

It would be useful to have an itemCount that takes into account quantities of different items in count. could be implemented as a virtual using 'get' function:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get

webpack-serve is now deprecated and should be replaced by webpack-dev-server

Version 1.4.0 of @types/url-parse was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/url-parse is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 16.4.7 of @types/react was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/memoize-one was updated from 3.1.1 to 3.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/memoize-one is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 11.1.0 of @types/yargs was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/yargs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 2.0.13 of react-native-i18n was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-i18n is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 4.3.0 of @types/react-router-dom was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react-router-dom is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 6.0.5 of @types/react-redux was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react-redux is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

https://github.com/brandingbrand/flagship/blob/master/packages/fscomponents/src/components/CMSBanner.tsx

Currently this component only defines a generic for props, meaning that components that extend CMSBanner cannot have their own state. We should update the type definition to add a state generic type.

Steps to reproduce:

• Download `react-native-camera'
• Init project
• Run project using yarn android

FAILURE: Build failed with an exception.

• What went wrong:
  Failed to capture snapshot of input files for task ':react-native-camera:compileReleaseAidl' property 'importDirs' during up-to-date check.

The library com.google.android.gms:play-services-basement is being requested by various other libraries at [[15.0.1,15.0.1]], but resolves to 12.0.1. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.

Version 1.4.3 of url-parse was just published.

This version is covered by your current version range and after updating it in your project the build failed.

url-parse is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 3.1.1 of react-native-push-notification was just published.

This version is covered by your current version range and after updating it in your project the build failed.

react-native-push-notification is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Version 1.0.3 of true-case-path was just published.

This version is covered by your current version range and after updating it in your project the build failed.

true-case-path is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

yarn audit suggests that we should update those dependencies to fix vulnerability

high:
ws >= 3.3.1

medium:
morgan >=1.9.1

low:
merge >=1.2.1
lodash >= 4.17.5

There have been updates to the react monorepoundefined

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency @commitlint/config-lerna-scopes was updated from 7.1.2 to 7.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@commitlint/config-lerna-scopes is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴