Giter Club home page Giter Club logo

ansi-php's Issues

`->reset()->lf()` and `->lf()->reset()` are not interchangable

it seems there is a difference between these 2 calls:

$ansi->color(SGR::COLOR_FG_RED)->text($text)->reset()->lf();

$ansi->color(SGR::COLOR_FG_RED)->text($text)->lf()->reset();

phpstorm and phpstan tell me that the 2nd example is an error. from a user point of view, I feel these should be the same thing

phpdoc-type: `color()`

the color method is typed with a array parameter for color.

ansi-php/src/Traits/EscapeSequences/SGR.php

Lines 47 to 55 in f581b2f

/**
* Shorthand to set the color.
* @param array $color The color you want to set. Use an array filled with ControlSequences\EscapeSequences\Enums\SGR::COLOR_* constants
* @return Ansi self, for chaining
*/
public function color($color = array())
{
return $this->sgr($color);
}

a lot of examples in the readme indicate that its finde to pass a single color.

static analysis tools like phpstan/psalm error about passing a single color, because of this array type

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.