Giter Club home page Giter Club logo

Comments (4)

bramski avatar bramski commented on June 25, 2024

This actually represents a chicken & egg problem for the service. The upgrade callback gets called when you try and use the database for the first time. So it's a dependency of the $indexedDB service to do the upgrade, e.g. the promise won't give you the DB handle until this upgrade is finished. Which is nice, as it guarantees your schema will be in place.

Probably you would need a broadcast even to make this possible. $scope.$on('indexedDB:upgradeComplete').

from angular-indexeddb.

bramski avatar bramski commented on June 25, 2024

I suspect you would have to put the actual firing of the event itself in some kind of $timeout to actually allow the callstack to return.

Seems simple enough but the devil is in the details. Have fun.

from angular-indexeddb.

davetclark avatar davetclark commented on June 25, 2024

That makes sense. Probably not worth the change. I think I could accomplish the what I want client side though if upgradeDatabase supported promises.

    $indexedDBProvider.connection('gfeclient')
        .upgradeDatabase(1, function (event, db, tx) {
            var objectStore = db.createObjectStore('store', {
                keyPath: 'key'
            });

            var deferred = $q.defer();
            objectStore.transaction.oncomplete = function (event) {
                var store = db.transaction(['store'], 'readwrite').objectStore('store');
                store.add({key: 'key', value: 'value'});
                store.transaction.oncomplete = function (e) {
                    deferred.resolve();
                }
            }
            return deferred.promise;
        });

The contract is that if .upgradeDatabase returns a promise, the next upgrade won't happen until the promise is resolved. Would you accept something like that?

from angular-indexeddb.

bramski avatar bramski commented on June 25, 2024

Sure. Write the PR and it'll happen.

from angular-indexeddb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.