Wrong usage of @defer.reject() about angular-indexeddb HOT 6 OPEN

What form of rejection would be preferred?

from angular-indexeddb.

IMHO actual error is enough.

Maybe it's a good idea to reject with object, like this:

@defer.reject({title: "Transaction Aborted", error: error})
@defer.reject({title: "Transaction Error", error: error})

from angular-indexeddb.

@bramski will it be useful if I write PR with this change?

from angular-indexeddb.

Yes for sure.
On Jul 11, 2016 3:13 AM, "Dmitriy Semyushkin" [email protected]
wrote:

@bramski https://github.com/bramski will it be useful if I write PR
with this change?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#65 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAZvlYKjxhqpR-PjdN3UUA3lF8317EIuks5qUhdNgaJpZM4I-4Sj
.

from angular-indexeddb.

Here you are:
#66

from angular-indexeddb.

Merged.

from angular-indexeddb.