Move all code inside the module definition about angular-indexeddb HOT 3 CLOSED

Sure. Feel free to open a PR. I'm otherwise uncertain when I'll get to
this as I'm not often using indexedDB in situations where it's not
supported!

On Saturday, October 25, 2014, James Messinger [email protected]
wrote:

Currently, the following lines are outside of the angular.module
definition, which means they run immediately when the file is loaded,
rather than waiting for angular.bootstrap to occur.

var IDBKeyRange, indexedDB,
__slice = [].slice;
indexedDB = window.indexedDB || window.mozIndexedDB || window.webkitIndexedDB || window.msIndexedDB;
IDBKeyRange = window.IDBKeyRange || window.mozIDBKeyRange || window.webkitIDBKeyRange || window.msIDBKeyRange;

The problem is that if I'm running in a browser that doesn't natively
support IndexedDB, and I'm loading a polyfill
https://github.com/axemclion/IndexedDBShim instead, then the above code
will only work if the polyfill is loaded before the
angular-indexed-db.js file. But if the polyfill is being loaded
dynamically (say, as an Angular module, a Require.js module, a Browserify
package, or a Cordova plugin), then the polyfill won't load in time, and
Angular-IndexedDB won't work.

To fix this problem, the four lines of code shown above just need to be
moved inside of the angular.module definition. That way, they won't run
until all dynamically-loaded scripts are finished loading and
angular.bootstrap is called.

—
Reply to this email directly or view it on GitHub
#4.

from angular-indexeddb.

Ok, will do. Just gotta get my Coffee Script set up first. :)

from angular-indexeddb.

Fixed. Closing.

from angular-indexeddb.