'IDBObjectStore': The transaction has finished. about angular-indexeddb HOT 3 CLOSED

Hey @Lunatic83 , this is not really an issue with the library. The problem here is that you are opening an XHR within your transaction. That's not going to work given the async nature of javascript based promises. You also cannot both error and attempt to insert something in your transaction. If your transaction results in error, your transaction will be rolled back.

My recommended refactoring..(

var getItemAndAddToDb;

getItemAndAddToDb = function(entityName, id) {
  return Restangular.one(entityName, id).get().then(function(result) {
    return $indexedDB.openStore(entityName, function(store) {
      return store.insert(result);
    });
  });
};

$indexedDB.openStore(entityName, function(table) {
  return table.find(id).then(function(item) {
    return item;
  })["catch"](function(error) {
    return getItemAndAddToDb(entityName, id);
  });
});

from angular-indexeddb.

I'm going to close this issue though as it's not really a bug persay. It would also be excellent if you could open & place your questions into stackoverflow and tag it "angular-indexed-db". That sort of method of first asking stack overflow questions seems most helpful to others who run into the same problems. Let me know when you open a question there and I am happy to direct you to a better solution.

from angular-indexeddb.

Huhz

On Friday, November 21, 2014, Bram Whillock [email protected]
wrote:

I'm going to close this issue though as it's not really a bug persay. It
would also be excellent if you could open & place your questions into
stackoverflow and tag it "angular-indexed-db". That sort of method of first
asking stack overflow questions seems most helpful to others who run into
the same problems. Let me know when you open a question there and I am
happy to direct you to a better solution.

—
Reply to this email directly or view it on GitHub
#12 (comment)
.

from angular-indexeddb.