the Modification structure is missing the number_of_billing_cycles field, which makes it impossible to get the default number of cycles of a discount/add-on ID, or the number of cycles of a discount/add-on within a subscription

Hello!

I'm just getting started with Braintree for my application, and it's really awesome to see this library that supports Golang for Braintree. However, I need escrow support for my application.

Is there anyone working on this?

Hey, I just got a 404 error here does that mean braintree may have changed it's API and this is now pointing to the wrong place ?

I am using the following code to create a subscription:

return s.Client.Subscription().Create(&braintree.Subscription{
    PlanId:             sub.PlanID,
    PaymentMethodToken: cc.Token,
})

Then I Marshal first return value and send to a browser, but have a panic:

 runtime error: slice bounds out of range
...
userspace/vendor/github.com/lionelbarrow/braintree-go.(*Decimal).MarshalText(0xc42043c8a0, 0x7c7b20, 0xc42043c8a0, 0xc42034d388, 0xc42043c8a0, 0xc4200a4b00)
/go/src/userspace/vendor/github.com/lionelbarrow/braintree-go/decimal.go:31 +0x202

Hey @eaigner, would you find the advanced search functionality described here or here useful? I was thinking of taking a crack at it this weekend.

Hi,

I would love to see support for the oauth gateway to enable using the partners API.

The documentation from braintree is here, and I believe the ruby equivalent is here.

Has anyone started working on it? Is anyone else interested?

I have not being able to see XML tag corresponding to Transaction.CustomerId field:

https://github.com/lionelbarrow/braintree-go/blob/master/transaction.go#L13

Is this a mistake or is it returned with XML in some cases?

The way to get customer ID from transaction object is Transaction.Customer.Id, because Transaction.CustomerId will always be empty.

Support for custom fields would be very helpful.

Correct me if I am wrong but if I want to create an API endpoint in Golang to parse Braintree webhooks, I will need to build HMAC signature in order to parse the webhook data.

So I would need to do something alongside these lines:

package api

import (
	"encoding/base64"
	"fmt"
	"io/ioutil"
	"log"
	"net/http"
)

// BraintreeWebhook - GET /api/v1/braintree-webhook/
func BraintreeWebhook(w http.ResponseWriter, r *http.Request) {
	// Request body cannot be nil
	if r.Body == nil {
		http.Error(w, "Request body cannot be nil", http.StatusBadRequest)
		return
	}

	// Read the request body
	payload, err := ioutil.ReadAll(r.Body)
	if err != nil {
		http.Error(w, "Error reading request body", http.StatusBadRequest)
		return
	}

	webhookGateway := testGateway.WebhookNotification()
	hmacer := newHmacer("my_public_key", "my_private_key")

	hmacedPayload, err := hmacer.hmac(base64.StdEncoding.EncodeToString(payload))
	if err != nil {
		http.Error(w, err.Error(), http.StatusInternalServerError)
		return
	}
	signature := fmt.Sprintf("%s|%s", hmacer.publicKey, hmacedPayload)

	notification, err := webhookGateway.Parse(signature, payload)
	if err != nil {
		http.Error(w, err.Error(), http.StatusInternalServerError)
		return
	}

	log.Print("Printing parsed notification: ")
	log.Printf("%v", notification)

	// business logic ...

	w.WriteHeader(http.StatusOK)
	fmt.Fprint(w, "Notification accepted")
}

The problem is the newHmacer function is not exported.

It would be to export this functionality so it can be imported by projects as currently I have to copy paste it.

Hi, I love the project and am trying to use full Go for a new site. According to this, it is recommended to provide device data when using a Vault record initiate a transaction. I do not see any way to provide this data using the Go lib. I have already collected the device data, just need a way to provide it to Braintree.

Thanks,
Rob

I have a branch adding support for subscription discounts and add-ons, so that'll be coming soon.

I keep getting a 'Signature-key pair contains more than one |' error when i try to parse a notification.

The signature i got from Braintree has 2 '|'. Am I missing something? Am i suppose to do something before passing the signature or payload?

Do you have documentation on the brain tree rest API. I read an article where they stated they only want to expose client API's and I would like to contribute to this one however without any documentation I am flying blind.

I'm trying determine the failure reason of bt.Customer().Find(customerID).

It returns an error (but not of any exported type) so I can't seem to distinguish between network errors, and the customer not actually existing.

The README states "If Braintree was able to process the request correctly, but was unable to fulfill it due to a semantic failure (such as the credit card being declined) then a BraintreeError type is returned.". The problem is that BraintreeError doesn't seem to be defined anywhere (just an unexported braintreeError), and it's not used for customer find anyways.

Please help me to shed some light on this. Thank you!

Trying to use the library from within Google App Engine yields a failure:

Fatal errorPost https://sandbox.braintreegateway.com/merchants/XXX/customers: http.DefaultTransport and http.DefaultClient are not available in App Engine. See https://cloud.google.com/appengine/docs/go/urlfetch/

It looks like using those calls are considered bad (same issue fixed in the OAuth library golang/oauth2#27 ).

Are you able to pitch a fix for that particular issue? I can help with testing if need be

I want to pay with paypal, but I can't find entrance to put my merchantAccountId when I generate the token.
So I try to create transcation or subcription with nonce and put my merchantAccountId in the transcationRequest or subcriptionRequest. It told me that Payment instrument type is not accepted by this merchant account.

PS: I try it in sandbox env

While using braintree-go at Daily Burn a while back, we noticed that the transaction search would only return the first 50 results or so, so we added paginated search results to the library.

Haven't been able to find the time to clean up our code and submit a proper PR but here is an example of what we did if someone wants to use as a reference to implement this if there's no existing way to do it https://github.com/dailyburn/braintree-go/commit/d44aa131caad6055c0e4aac2f3a24450aa818c63

Hello,
Is there a way to generate a sample webhook notification like in other drivers ?
I can work on a PR if needed.
Thanks

I've tried many variations but whatever I do it doesn't seem like I can apply a discount to a new subscription (the []interface{} type of Subscription's Discounts field isn't very helpful in this regard either).

The returned error is Forbidden (403) in all cases.

E.g. Plan.NumberOfBillingCycles may be empty in the response XML from Braintree, but is otherwise an integer. We currently deserialize to a string to avoid this issue.

Possible solutions:

• Create types that can either be an int (or bool, float, etc.) or nil and use those (similar to sql.NullInt)
• Make use of https://github.com/guregu/null which does this work, but would require us to introduce a third-party dependency and expose that dependency to the end user

I noticed that the official Ruby sdk is using Api version 4 of braintree, but Braintree-go is still on version 3.

I'm not sure of what the differences are, and 3 still seems to work fine, but it's perhaps worth looking into by someone who knows.

I am trying to use your library for developing an application. On that i am using drop-in UI. that sends payment_method_nonce. I can manage successful transaction using this, But the problem is i can not use this while subscribing a plan. I have customer info coming from another source. So when adding customer i do not have any credit card information. So i need to add payment Method from nonce when user submits the drop-in ui forms.

On Php
On Java

Is there anything for this go lib? if not do you have it in mind to implement in near future?

Thanks for writing this library.

I did not find out how to create a transaction with the id 'dskdmb' to run the tests successfully.

Hi,

Thank you for building this go package for braintree.
I may have found a possible issue that I want to bring to your attention.

When I run the code mentioned below, the transaction got approved but the tx.CreditCard.Token (tokenized credit card number) field is not set. Can anyone fix this please?

    bt := braintree.New(
	braintree.Sandbox,
	"47sdtstnwjp8xy7k",
	"nxf5g2kx2wgdtrrs",
	"********************************",
)

ctx := context.Background()
tx, err := bt.Transaction().Create(ctx, &braintree.TransactionRequest{
	Type: "sale",
	Amount: braintree.NewDecimal(100, 2), // 100 cents
	CreditCard: &braintree.CreditCard{
		Number:         "4111111111111111",
		ExpirationDate: "05/14",
	},
}) 

I am curious how to use contexts with this library in a secure way.

Let's use this example:

ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()

customer, err := api.Customer().Find(ctx, "customerID")

// do some other work that might take some time

pm, err := api.PaymentMethod().Create(ctx, &braintree.PaymentMethodRequest{
    CustomerId:         customer.Id,
    PaymentMethodNonce: "nonce",
})

If the context get canceled during the PaymentMethod().Create() we can get into a state where we think the api call failed, but it actually was successful.

You could argue to just increase the timeout of the cancel to 2 minutes, but even this would be insecure because of the additional time spend between the 2 calls to braintree.

Even if you only use context without timeouts you need to make sure to never cancel those in the first 60s of a braintree api call.

I didn't find an easy way to use contexts in a secure way.

When Braintree is sent invalid input, it returns an error object that contains both a global summary of what went wrong and field-specific error messages. For example in the Ruby client library:

result = Braintree::Customer.create(
  :credit_card => {
    :number => "bacd123",
    :billing_address => {
      :country_name => "mars"
    }
  }
)

You can then do both this (which is what the Go library currently supports):

result.message
>>>> "some error message"

and this:

result.errors.for(:credit_card).for(:number)
>>>> "credit card number must be numeric"
result.errors.for(:credit_card).for(:billing_address).for(:country_name)
>>>> "mars is not a country"

This allows for people to be more specific when displaying errors to their user. I'll investigate possible ways for us to support this.

Hi, I'm trying to add refunds. When trying to test, it seems that I need to do a PUT to /transactions//settle in order to settle a transaction, before refunding it. For some reason this returns 404, can you please advice how it can be done?

Thanks,
Kiril

Passing contexts around for timeouts, cancellation, and other behaviors is now common and well-documented in Go land. It'd be really nice to have support for that in braintree-go. Even Context versions of the methods like how database/sql was updated would work.

Hi, I've been using braintree-go and I've come into an issue where I'm trying to update a customer's credit card billing address without using a payment method nonce, and I'm getting the "Gateway Rejected: cvv" error response.

I have the VerifyCard field set to false in CreditCardOptions, which I believe should help me avoid getting this error response.

Anyways, my code is at the bottom. Let me know if anyone else has seen this same issue or if I'm doing anything incorrectly.

c, err := s.api.Customer().Update(
	&braintree.Customer{
		Id: req.UserToken,
		CreditCard: &braintree.CreditCard{
			Options: &braintree.CreditCardOptions{
				UpdateExistingToken: req.PaymentMethodToken,
				VerifyCard:          false,
			},
			CardholderName: req.CardholderName,
			BillingAddress: &braintree.Address{
				StreetAddress:     req.BillingAddress.StreetAddress,
				ExtendedAddress:   req.BillingAddress.ExtendedAddress,
				PostalCode:        req.BillingAddress.PostalCode,
				CountryCodeAlpha2: req.BillingAddress.CountryCodeAlpha2,
			},
		},
	},
)

Following the docs here:
https://developers.braintreepayments.com/guides/recurring-billing/create/ruby

The Subscription struct should therefore contain a payment method nonce.

Hi,

I'm building a software that tokenizes credit card numbers using your Go package and would very much appreciate if you guys can add this following functionality.

I want to get a token (Credit card number that is tokenized) from Braintree without making a sale (i.e) I want Braintree to give me a token back without charging the credit card.

Thanks,

I'm using your example server.go with form.html and when I feed it my values it gives back an Unauthorised 401 - known issue?

Have I missed a step? I ran go run server.go and hit it at localhost with a demo credit card of:
"4111111111111111"
"05/2010"
"100"

which should succeed. I even hardcoded my merch details into the app for testing and still unauthorised.

I know this would break the API, but how do you feel about swapping out the float64s currently being used for amounts with big.Rats to avoid losing precision?

Seems to be missing in current structures but is present on Braintree page. Could send a PR adding this field to struct. Any thoughts against such modification?

Hey,

While right now we can use NewWithHttpClient to pass in our own HTTP client, would it make sense to choose a sensible default for the Timeout field instead of using net/http's default client (which has no timeout)?

I went through our codebase after reading this post, so just dropping notes where I can.

Thanks for the renewed attention for this package by the way. Using it in production and it's been great! Any chance Braintree will "officially" support this one?

Hi there,

I've looked and there doesn't seem to be a Refund capability for settled transactions at the moment. Could you confirm this?

If so, can I put it as a function of TransactionGateway in a pull request? It looks like it should be a POST to "/transactions/#{transaction_id}/refund" with params: transaction => {:amount => amount})

Thanks!
Thomas

Would be nice to add this function:

https://developers.braintreepayments.com/reference/request/subscription/search/python

Hi, I'm looking at using Go to talk to Braintree and found this library. I'm wondering if it's been used in anything serious and whether it will continue to be maintained?

Thanks.

We should add a CHANGELOG to the project that outlines significant changes and new features between releases. As this package is still pre-v1 there may be small breaking changes in the exported api and this will be one place we can also highlight them between pre-v1 versions, and between major versions when we have them.

Suggested by @jszwedko in comments on #120.

I'd need the subscription api to get going with Braintree.

Hi,

Moving some processing from PHP to Go.

I'll provide some context...

I'm using RiskData per here: https://developers.braintreepayments.com/reference/response/transaction/php#risk_data

Which is something like:

$result = Braintree_Transaction::sale([
	...
    'riskData' => Array(
		'customerIp' => $this->ci->input->ip_address(),
		'customerBrowser' => substr($_SERVER['HTTP_USER_AGENT'], 0, 254) // 255 Characters Max
	)
]);

I've seen that the Transaction struct contains DeviceData, so that's customerBrowser sorted.

Where would I be able to submit the IP?

Thanks

We need to use other currencies other than Euro on our system. There seems to be no support for currencies on Transactions implemented, so we added:

CurrencyIsoCode string xml:"currency-iso-code,omitempty"``

to transaction.go

Yet, when we try to process a transaction:

tx, err := bt.Transaction().Create(&braintree.Transaction{
  Type: "sale",
  CurrencyIsoCode: string(b.Currency),
  Amount: braintree.NewDecimal(int64(b.Total*100), 2),
  PaymentMethodToken: cc.Token,
})

we get on the response the error:

Forbidden (403)

Does it have to do with the implementation or the account definition ?

Hello! Thanks for the great library. It's exciting to see so much great work being done on it!

I've got a branch based on a fairly old revision that implements a couple more transaction fields (and some alternative implementations of great work you've done since then). I haven't updated to the latest revision, but in a few months when I do, I'd be able to submit a pull request, but I wanted to ask first—would you prefer a PR at that point, or just a note that I'd use them if you added them?

Hey,

given the fact that Braintree will drop TLS support for less than 1.2, would you accept a PR that sets this as the default minimum TLS version to be used by the actual HTTP client?

Hello Lionel,

Great work with the library. I'm trying to create a Transaction with the PaymentMethodNonce property instead of using a direct Credit Card payment but keep hitting a 403. This nonce value is retrieved after my server returns a client token and the client tokenizes their payment through paypal. Here's roughly how the process looks like:

bt = braintree.New(braintree.Production, merchId, pubKey, privKey)

Client asks for a client token:
token, err := bt.ClientToken().Generate()
//return this token to client

//paypalInstance now uses this token to tokenize a nonce payload and then I send this to my server. I then process this nonce into a Transaction:

nonce := r.URL.Query.get("nonce")
tx, err := bt.Transaction().Create(&braintree.Transaction{
Type: "sale",
Amount: amount,
PaymentMethodNonce: nonce,
MerchantAccountId: "USD",
})

if err != nil {
logger.Debugf("Failed to create transaction: %v", err)
http.Error(w, "", http.StatusInternalServerError)
return
}

I've checked with braintree and paypal payment method is enabled so I'm not sure if this is the correct implementation for nonce payments.

https://github.com/lionelbarrow/braintree-go/blob/95dec3d454ce596f89da7e18822aa7796c8641e7/test_values.go#L78

It is impossible to use flags in main package because of this.

Possible dumb question: How do I create a transaction in the Braintree sandbox with a specific Transaction ID? I don't see a way through the web-console interface or the API to create a transaction with a specific ID.

If we specify the tags with a leading v, people can use this library with http://labix.org/gopkg.in. This might be nice while the API is still stabilizing.

Reference: http://labix.org/gopkg.in#SupportedURLs

Hello,

How can I get signature from *http.Request object in my handler where I want to parse a webhook notification like this:

payload, err := ioutil.ReadAll(r.Body)
if err != nil {
	http.Error(w, "Error reading request body", http.StatusBadRequest)
	return
}

bt.WebhookNotification().Parse(signature, string(payload))

I assume payload is just the content of HTTP POST data but where is signature? In one of the headers?