brainsia / brainsstandalone Goto Github PK

When packaged within Slicer, there are extra folders named ''include'' and ''lib'' at the root of the bundle. These ones corresponds to the development headers/files of BRAINSTools.

To avoid these extra files from being installed. An option named BRAINSTools_INSTALL_DEVELOPMENT could be added.

Aware these files are already associated with the Development component, this option can provide an easy way to enable/disable their installation without having to specify the explicit list of components that should be installed within Slicer. See https://github.com/Slicer/Slicer/blob/master/SlicerCPack.cmake#L60

A similar approach is followed within VTK and CTK

Please see comment associated with the following commit: 8778dc5

This is causing issue in packages like Slicer where the library is expected to be packaged.

See https://github.com/BRAINSia/BRAINSStandAlone/blob/master/GTRACT/Common/CMakeLists.txt

This morning Slicer dashboards started to fail with the following message:

fatal: reference is not a tree: 03ce71cca9bbfb1f0da0040b139011211694b1c6
CMake Error at BRAINSTools-prefix/tmp/BRAINSTools-gitclone.cmake:28 (message):
  Failed to checkout tag: '03ce71cca9bbfb1f0da0040b139011211694b1c6'

See http://slicer.cdash.org/viewBuildError.php?buildid=20596

The error is reproducible doing the following:

$ git clone git://github.com/BRAINSia/BRAINSStandAlone.git BRAINSTools
$ cd BRAINSTools
$ git checkout 03ce71cca9bbfb1f0da0040b139011211694b1c6
fatal: reference is not a tree: 03ce71cca9bbfb1f0da0040b139011211694b1c6

The branch SlicerITKv3Patches has been deleted from BRAINSSia/BRAINSStandAlone repository, would be great if it could be restored.