Giter Club home page Giter Club logo

Comments (7)

adamltyson avatar adamltyson commented on May 17, 2024

That's a good idea, and it's an issue that I've come across with amap and cellfinder. Until now I've avoided it because they're not yet at a stable version. However, this project could reach stability, and still undergo lots of changes to the atlases.

Do we want to start trying to support old versions of the API/atlas? This could be a headache avoided with a message asking people to upgrade.

from brainglobe-atlasapi.

FedeClaudi avatar FedeClaudi commented on May 17, 2024

I think for now, since things will be changing a lot and rapidly we can just ask people to us the updated version. Once development slows down we can start supporting different versions?

from brainglobe-atlasapi.

vigji avatar vigji commented on May 17, 2024

Youp, I also agree that priority is to automatically detect if it is outdate and trigger redownloading. I was not thinking about supporting old versions of the atlases, just to somehow map in the brainatlas-api version the version of the atlases it is working with. This way matching the correct (old) version of the atlas to be used is not that different from updating to the most recent one

from brainglobe-atlasapi.

vigji avatar vigji commented on May 17, 2024

In this direction, probably it make sense to put the scripts to generate the atlases back in a separate folder of this repo, so that they are versioned together?

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on May 17, 2024

Could each atlas just have unique metadata entry, so we know what version of what atlas we are using (like Allen_10um_2020-05-27a)?

We can prompt people to upgrade to a new version of the API (and therefore atlases) with something like this in __init__.py

__name__ = "brainatlas-api"

import luddite
from packaging import version

most_recent_version = luddite.get_version_pypi(__name__)

if version.parse(__version__) < version.parse(most_recent_version):
    print(
        f"This version of {__name__} ({__version__}) is not the most recent "
        f"version. Please update to v{most_recent_version} by running: "
        f"'pip install {__name__} --upgrade'"
    )

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on May 17, 2024

In this direction, probably it make sense to put the scripts to generate the atlases back in a separate folder of this repo, so that they are versioned together?

Maybe, but this could stop being useful as soon as anyone else makes an atlas that we incorporate.

from brainglobe-atlasapi.

FedeClaudi avatar FedeClaudi commented on May 17, 2024

I think we are happy with how things are now? Should we close?

from brainglobe-atlasapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.