Giter Club home page Giter Club logo

Comments (9)

adamltyson avatar adamltyson commented on June 6, 2024 2

This isn't a bug in the atlasapi, the validation script explicitly updates the atlas. Maybe the validation script should have some logic to deal specifically with atlas versions that are newer than those on GIN?

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on June 6, 2024 1

You can keep it open, just maybe change the title so we know what the actual issue is.

As an aside, I've actually just disabled Discussions. We decided a while back to not use that feature (in favour of issues, Zulip & image.sc), and I didn't know we still had it enabled on this repo.

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on June 6, 2024

Detect the difference but don't replace the atlases automatically.

What was done automatically? Nothing in BrainGlobe should update the atlases without specific user interaction.

from brainglobe-atlasapi.

viktorpm avatar viktorpm commented on June 6, 2024

It started to download the atlases without me running the brainglobe update -a kim_mouse_25um (or any other) command.

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on June 6, 2024

What started to? What process was running?

from brainglobe-atlasapi.

viktorpm avatar viktorpm commented on June 6, 2024

I ran the validation.py function. This is the output:

(bg-atlasapi) vplattner@hpc-gw1:~/_projects/validation/brainglobe-atlasapi$ python brainglobe_atlasapi/atlas_generation/validate_atlases.py
example_mouse_100um 1.2
allen_mouse_10um 1.2
allen_mouse_25um 1.2
allen_mouse_50um 1.2
allen_mouse_100um 1.2
mpin_zfish_1um 1.0
allen_human_500um 0.1
/nfs/nhome/live/vplattner/_projects/validation/brainglobe-atlasapi/brainglobe_atlasapi/core.py:65: UserWarning: This atlas seems to be outdated as no additional_references list is found in metadata!
  warnings.warn(
kim_mouse_10um 1.0
brainglobe_atlasapi: kim_mouse_10um not found locally. Downloading...
Downloading... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100.0% • 645.2/645.2 MB • speed: 1.8 MB/s • ETA: 0:00:00
kim_mouse_25um 1.0
brainglobe_atlasapi: kim_mouse_25um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_25um
brainglobe_atlasapi: kim_mouse_25um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_25um
brainglobe_atlasapi: kim_mouse_25um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_25um
brainglobe_atlasapi: updating kim_mouse_25um
Downloading... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100.0% • 226.7/226.7 MB • speed: 1.1 MB/s • ETA: 0:00:00
brainglobe_atlasapi: kim_mouse_25um updated to version: 1.0
kim_mouse_50um 1.0
brainglobe_atlasapi: kim_mouse_50um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_50um
brainglobe_atlasapi: kim_mouse_50um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_50um
brainglobe_atlasapi: kim_mouse_50um version 1.1is not the latest available (1.0). To update the atlas run in the terminal:
    brainglobe update -a kim_mouse_50um
brainglobe_atlasapi: updating kim_mouse_50um
Downloading... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╺━━━━━━━━ 87.8% • 167.2/190.5 MB • speed: 1.1 MB/s • ETA: 0:00:21

from brainglobe-atlasapi.

adamltyson avatar adamltyson commented on June 6, 2024

Can you link to that file?

from brainglobe-atlasapi.

viktorpm avatar viktorpm commented on June 6, 2024

Sure! https://github.com/brainglobe/brainglobe-atlasapi/blob/main/brainglobe_atlasapi/atlas_generation/validate_atlases.py

from brainglobe-atlasapi.

viktorpm avatar viktorpm commented on June 6, 2024

Should I convert this into a discussion or close it?

from brainglobe-atlasapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.