braftonsupport / braftonium Goto Github PK

make sure screen readable

youtube didn't quite work right

dont use display:none;

hide w/ position: absolute; and brought into view on :hover, :focus, and are navigable using either the tab key or by using the keyboard arrow keys.
How to test:

Using tab key, tab forward through site. Test to make sure that links, buttons, form fields, and dropdown menus are available using the tab key.
Make sure you can see visually which link is focused.
Test shift+tab to move backwards and confirm that works as well.

seperate out them options creating seperate tabs for blog ect

add the required markup into functions.php and ensure the theme will easily support woo commerce adding in templates for products

they ugly

needs client's google api key. Option for phone 3(s) and email(s)

Themes must include a mechanism that enables users to navigate directly to content or navigation on entering any given page. These links may be positioned off screen initially but must be available to screen reader users and must be visible on focus for sighted keyboard navigators.

A minimally conforming skip link must:

Be the first focusable element perceived by a user via screen reader or keyboard navigation.
Be visible when keyboard focus moves to the link.
Move focus to the main content area of the page when activated.
There is an outstanding bug in WebKit-based browsers that prevents focus being moved to elements that aren’t natively focusable. You can either enqueue JS to patch this bug or assign tabindex=-1 to your main content region to handle this issue.

How to test:

Verify that skip link is present.
Verify that skip link is first focusable object on the page when not logged in
Verify that skip link becomes visible when it receives focus
Verify that skip link points to the content area of the site correctly
Tools: browser tab key, browser inspector

https://docs.woocommerce.com/document/template-structure/

"If your theme has a woocommerce.php file, you will be unable to override the woocommerce/archive-product.php custom template in your theme, as woocommerce.php has priority over other template files. This is intended to prevent display issues."

Is this file needed? Can it be deleted? I am trying to customize that file for my site. Thanks!

Headings do not skip levels when descending. H1 cannot be followed by H3, etc.

All punctuation is removed from the image path for the Braftonium Logo... probably just an issue with the sanitization of the URL for the braftonium_logo setting in braftonium-options.acf.php

need an option to change the blog layout between the 2-3 options we already have and an easy way to add more blog layouts just by putting a new template file into a "blog" folder or something

Hayley will be providing more specifics as to trends in padding per section, in the meantime, decrease padding between sections by 30%

only include if using the testimonial block

https://github.com/BraftonSupport/legoblox/blob/b3190db5b5fe31a081bdfdd37eaebf33c6c790b9/header.php#L19-L73

This all needs to be inside the head tag

upon activating theme on existing site menu shows as regular unordered list not as a menu

your terms are not translating because here youll notice your terms are outside the translation method

NOTE: also you defined Teammember not teammebersS with an s so another reason

Add

Text Domain: transparent

to the theme definition style.css file

1. WP_DEBUG, true
2. if ( ! defined( ‘ABSPATH’ ) ) exit; // Exit if accessed directly
3. Sanitize all the inputs
4. Escape all the outputs
5. Nonce your forms and urls

https://github.com/BraftonSupport/legoblox/blob/b3190db5b5fe31a081bdfdd37eaebf33c6c790b9/library/custom-fields/fields.php#L3

since yoru changing the theme name ensure you properly check all your folder paths this still says business theme-2

All things having to do with custom post types should be in the plugin

ensure all echo statments and options use the proper _() translation function to ensure the theme is multilanguage compatable

Maybe it can be like that Image + Text guy but repeating.

you have other need better name (options)

compact and thin need better names

Checkbox options to add to classes?
-add shadow
-full screen
-full width
-compact
-thin

library/braftonium.php

a common, 3 character minimum prefix would be considered best practice by Wordpress.

XXX_existing_function_name()

functions:

excerpt_more
page_navi
related_posts

initilization of theme settings occurs before your textdomain and translation loading. all your logic needs to be inside braftonium_start method

this is super lightwieght and combined with wowjs you can get animation as you reveal elements with some simple css classes.
http://kristofferandreasen.github.io/wickedCSS/documentation.html

take a look after the current build and see about adding this in as options to entire sections or single elements like buttons and images

Any custom features, templates, options or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided.

This could very well raise a flag with Wordpress. I would consider replacing lines 37 to 55 in full-width.php with the following:

$row_layout = get_row_layout();
get_template_part( 'post-formats/content', $row_layout);
$sectionrow++;

Appropriate usage of roles:
role="banner" == header (

no more than 10!!!

match different blog styles to theme customization

images need to be clickable

As the theme requires the Advanced Custom Fields plugin for its options pages, this plugin will need to be bundled correctly with the theme. Wordpress throws one warning and one fatal error on theme activation if that plugin does not exist in the destination install.

Here is one option for dependency management:
https://github.com/TGMPA/TGM-Plugin-Activation

An alternative would be to use Wordpress native meta fields. I have taken this approach with a custom theme I am developing.

should probably have a custom post type and or a category option.

and related posts,
fix and test

Links (not nav or buttons) within content must be underlined.

Add a new svg for a shopping cart icon.

Fails:
the_content(
__( 'Continue reading', 'textdomain' )
);

Passes:
the_content(
sprintf(
__( 'Continue reading%s', 'textdomain' ),
' '.get_the_title().''
)
);

automatically adds style to the events/testimonial/whatever custom post type in braftonium/library/custom-fields/master.scss

Use Theme-check and test data to test the theme before sumbitting
https://wordpress.org/plugins/theme-check/

follow this page and prefrom each of these tests
https://codex.wordpress.org/Theme_Unit_Test
with this data
https://raw.githubusercontent.com/WPTRT/theme-unit-test/master/themeunittestdata.wordpress.xml

banner not allowed

Have a valid DOCTYPE declaration and include language_attributes.
Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: Data Validation)
No removing or modifying non-presentational hooks.

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. Theme nav menu locations and sidebar IDs are exceptions.

need a block that allows you to select widgets to add to the page

The content templates in the post-formats folder have script tags embedded within the HTML. This practice is strongly discouraged by Wordpress. I would consider removing them and adding them to an external file or function passing the required $videoid variable as a parameter. You would also be removing unnecessary code duplication as well since the scripts appear to be identical.

The theme requires actived acf to work. using theme activeation hook, active the plugin using https://codex.wordpress.org/Function_Reference/activate_plugin. if the plugin doesn't exist display message to user to install the plugin and stop theme activation