bradenaw / juniper Goto Github PK

It would be good to see benchmarks with std lib such suite would help improve the library. I can help with that if the author of this project is willing to drive the project on this direction.

tree.Range requests Bound as parameters, but for making Bound there is no access to type boundType and its values. The most usefull b-tree search functions are inaccessible due names without reason.

• 1.17 ?
• 1.18 ?

It would be nice to have a Group-By function for collections like https://www.scala-lang.org/api/2.12.7/scala/collection/Iterable.html#groupBy[K](f:A=%3EK):scala.collection.immutable.Map[K,Repr]
or (in Go before generics):
https://github.com/ahmetb/go-linq/blob/master/groupby.go

In 0ecc9cb

The value of go in go.mod was increased from go 1.18 to go 1.21.

This forces all users of this package to upgrade their go to 1.21

$ go get github.com/bradenaw/juniper
go: upgraded go 1.19 => 1.21
go: added toolchain go1.21.3
go: upgraded github.com/bradenaw/juniper v0.13.1 => v0.14.3

I'm not sure if that was your intention or not. Being able to support old versions is very useful for a library and if this library works with go 1.18 then I suggest you revert the go.mod change and set it back to go 1.18. If it doesn't work with go 1.18 then pick the oldest version of go it does work with.

Happy to send a PR for this if you think it is a good idea.