bpolaszek / bentools-etl Goto Github PK

Hi 👋

Thank you very much for this lib. I managed to implement a full, custom ETL workflow and all went smoothly.

Using PHP 8, I got those two warnings, though:

PHP Warning:  "resource" is not a supported builtin type and will be interpreted as a class name. Write "\Safe\resource" or import the class with "use" to suppress this warning in vendor/thecodingmachine/safe/generated/sockets.php on line 797
PHP Warning:  "integer" will be interpreted as a class name. Did you mean "int"? Write "\Safe\integer" or import the class with "use" to suppress this warning in vendor/thecodingmachine/safe/generated/swoole.php on line 17

I guess this is because the referenced version of the thecodingmachine/safe lib is quite old.

Explicit flush action is not working when setting $flushEvery to 0:

  [Symfony\Component\Debug\Exception\FatalThrowableError]  
  Modulo by zero   

Contract of a Transformer is to return a \Generator.

When a transformer returns a Generator with either:

• Duplicate keys
• Objects as keys

Loader doesn't receive the accurate items to load.
In the 2nd case, a Illegal offset type error warning is raised.

This is due to the ETL process which requires to traverse generators and build them back again before sending them to loaders, so as to allow hooking on transformation errors and safely dismiss an item which failed to be transformed.