bpepple / thwip Goto Github PK

Feature Request
Add admin functions to refresh the data from Comic Vine.

Solution
Just need to update the functions in the comicimporter (mainly limiting the number of request per hour), so the user doesn't exceed Comic Vine's rate limit. Could do this will a simple time.sleep() or using requests-respectful (tho I'm hesitant to add the dep since the project seems fairly dead, and doesn't play well with parallel tasks like celery) .

Not a pressing issue, so I'll back burner this until I get more time to look into a decent solution.

If this would be a big change, feel free to roundfile.

I have comic archives that shouldn't be changed for data consistency purposes (checksums change, etc) but it would be trivial to add the comicvine id info to the filename.

Would it make sense to support checking the filename for something like [CVDB154258]? I guess it could be [4000-154258] as well but that seems redundant and non-specific.

First off, Many, many thanks for Thwip! I really enjoyed BAMF and this looks like an awesome replacement. I really appreciate the work you've put into both applications.

Describe the bug
Scaling on an android tablet or phone is no fun at all. Please see the first screenshot as an example.

To Reproduce
Steps to reproduce the behavior:
Open on mobile

Expected behavior
A mobile friendly interface

Screenshots
Before Change:

After change:

Desktop (please complete the following information):

• OS: Android
• Browser: chrome on mobile
• Version: 73.0.3683.90

Additional context
I am not a developer in any way, shape, or form, but my goal was to try and find a solution before I cried for help. That said, I was able to get this to scale on my mobile devices by changing line 5 in public/index.html from:
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
to:
<meta name="viewport" content="shrink-to-fit=yes">
It has so far worked great on my devices. I'm not sure how it affects anything else though.

Currently the reading status & leaf are set on a global level (issue), and it would be nice to have that be a per-user basis instead.

It would entail adding a new model like this (for example) and removing the corresponding Issue model fields:

class ReadStatus(models.Model):
    STATUS_CHOICES = (
        (0, 'Unread'),
        (1, 'Partially Read'),
        (2, 'Read'),
    )
    user = models.ForeignKey(settings.AUTH_USER_MODEL, blank=True, null=True, on_delete=models.CASCADE)
    issue = models.ForeignKey(Issue, blank=True, null=True, on_delete=models.CASCADE)
    leaf = models.PositiveSmallIntegerField(editable=False, default=0, blank=True)
    status = models.PositiveSmallIntegerField(choices=STATUS_CHOICES, default=0, blank=True)

    class Meta:
        unique_together = ['user', 'issue']

And then would need to modify the serializers & views for the change. On the frontend, we would need to rework the code a bit (primarily in the Reader).

Feature
Would be nice to have the story arc information available to make multi-series story arc reading easier.

Solution
Pull the story arc information from Comic Vine and provide a view where the story arc issue are shown (preferably in the correct reading order).

Additional information
Not an issue pulling the information from Comic Vine. I believe they don't sort the issues by reading order in the api (tho, I need to verify that is true). If they don't, we would need to add this to our models, and add the appropriate methods to the api.