bpedziwiatr / datavers-gen-cli Goto Github PK

Input: EnvironmentVariableDefinition entity to be generated for c# model
output: fields class contains two definitions for schemaName since Schemaname is generated from entity schema name and Schema name field on EnviromentVariableDefinition.

public const string SchemaName = "environmentvariabledefinition";
public const string SchemaName = "schemaname";

suggested fix: rename Schemaname generated from entityname to EntitySchemaName

find a solution to store connection string in secure way without need to remeber of removing security values from config

Generate one file with type for all tables included in generator.
export type DataverseTabels = "account" | "contactn"...;

Example:
{ "Entities": ["account", "contact", "systemuser" ], "ConnectionString": "", "Namespace": "Dataverse.Entities", "OutDirectory": "Entities", "TemplateName": "ProjectTemplate", "TemplateEngine": { "IsSingleOutput": false, "Name": "scriban", "Type": "C#" } }

Change WelcomeXml to meet eslint requirments:

• remove space on end of the line
• add space after //

Example:

        WelcomeXml = $@"

// ------------------------------------------------------------------------------
//
// This code was generated by a Dataverse-Cli.
// Runtime Version: {assemblyVersion}
// File Version: {assemblyFileVersion.FileVersion}
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
//
// ------------------------------------------------------------------------------";

Add information in console log what entities where found

Unhandled Exception: Scriban.Syntax.ScriptRuntimeException: (259,7) : error : Exceeding number of iteration limit 1000 for loop statement.

Need to change:

Cannot implicitly convert type 'Contoso.Dataverse.DataAccess.Entities.Dataverse.SystemUser' to 'System.Collections.Generic.IEnumerable<Contoso.Dataverse.DataAccess.Entities.Dataverse.SystemUser>'. An explicit conversion exists (are you missing a cast?)

add explicit type:

get => (IEnumerable<{{attribute.to_entity.hybrid_name}}>) GetRelatedEntities<{{attribute.to_entity.hybrid_name}}>("{{attribute.schema_name}}",{{attribute.entity_role}});

fix name of files and types generated

{{info.welcome_xml}}
namespace {{ namespace }}
{
public partial class {{entity.hybrid_name}}
{
public class Enums
{
{{for enm in entity.enums}}
public enum {{enm.display_name}}
{
{{for item in enm.items}}
{{if item.name != "is" }}
{{item.name}} = {{item.value}},
{{else}}
{{item.name}}_ = {{item.value}},
{{end}}
{{end}}
}
{{end}}
}
}
}

Example:
return crmQuery.Where(p => p.erpid == erpid && p.company.Name.Equals(companyId)); //this will return error/invalid query
Example thah works:
return crmQuery.Where(p => p.erpid == erpid && p["companyname"].Equals(companyId)); //this will work

What should be possible:
return crmQuery.Where(p => p.erpid == erpid && p.companyName.Equals(companyId)); //this will be equal to example above

for example when you have table names: xxx_table1 and field xxx_table1 you will receive an error from c# that prop name cannot be the same as class name.

When CLI is used following file is created in target folder "dataversetemplate.cs".
Content of the file:

Add to config path to csproj
add generated files to csproj
remove not generated files from csproj
remove not generated files from generated folder

If possible ship it to chocolety repository

Error handling, when you don't have added credentials in the config file.

if attribute has same name as entity, we get error on genrated C#

Issue:
When creating metadata for ts optionset keys do not match exactly optionset labels from CRM. See example in the image below (whitespace and special characters are removed)

Example Expected OptionSet label (Enum Key) "Potwierdź Zamówienie"
Example Actual Enum Key "Potwierdzzamowienie"

1. every entity added by internal logic should be optional, so in this case adding activityparty should result in generation of only one entry in XrmServiceContext
2. There should be validation for duplicated entries in entities list

//ascii art//

• Version 1.3.4.5

Check code with resharper do some preformance improvment with linq

Try To load all entities and then check for those needed from config

The latest version (1.3.0.18) has the incorrect System.Threading.Tasks.Extensions.dll version in the zip file.

Version from the older release works flawlessly.

@C485 working on it,
.net 5 with new sdk

Change config.json to dataversegen.config.json

Description contains line breaks
Remove line breaks from descripotion.

Spamming waiting for connection 1000ms instead of throwing an error like prev version (1.3.1.33 works fine)

Remove code to load all entities and search for entities
To simpolify request for metadata