CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Console\Bow.php:318-334
src\Console\Bow.php:429-445

• Version: 4.0
• PHP Version: 7.2
• Database Driver & Version: Mysql

Description:

The PUT Request data is parse when the content type is application/json and not x-www-form-urlencoded etc...

Steps To Reproduce:

Send the request with PUT method in any route bind the PUT method.

CodeFactor found an issue: Comment refers to a TODO task "Implement move() method"

It's currently on:
src\Resource\Ftp\FTP.php:260

CodeFactor found an issue: Empty return statement not required here

It's currently on:
src\Support\Console\Command.php:327

CodeFactor found an issue: Empty return statement not required here

It's currently on:
src\Console\Command.php:657

Idea

You can create a seed helper like this seed('users', 5); for make programmic seeding.

Eg: we can use it in the unity test.

public function testDeleteUser()
{
   // We can seed the user if is necessary
   seed('users', 2);

   $response = $this->delete('/api/v1/users/1');
   $response->assertStatus(200);
   ....
}

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Console\Command.php:519-583
src\Console\Command.php:889-955

• Version: 4.0
• PHP Version: 7.2
• Database Driver & Version: Mysql

Steps To Reproduce:

To create the user you can make this

$user = App\User::first();

$user->name = "Bow";
$user->save();

// And you save again
$user->save();
// That error occured 

How to debug it:

Considered the line 469 to 480 of the src/Database/Barry/Model.php

$update_data = [];

foreach ($this->attributes as $key => $value) {
   if (!isset($this->original[$key]) || $this->original[$key] != $value) {
       $update_data[$key] = $value;
   }
}

In this code we collect the necessary values to make update. So, when there are not value and $update_data is empty. The final update SQL Query equal to update table set where (id = :id).

CodeFactor found an issue: String concat is not required here; use a single string instead

It's currently on:
src\Logger\Logger.php:64

Description:

@papac, this is about enhancing Hash class.

I've notice that the Hash class uses the PASSWORD_BCRYPT const directly.

It's not friendly because developers cannot choose their desired password hash algorithms.

My suggestions are as follows:

• Using the configuration to set the current password hash algorithms.
  And setting the PASSWORD_BCRYPT constraint value by default.
• Adding the constructor in Hash class to let developers set current setting before using the Hash class to do password hash work.

CodeFactor found an issue: Duplicate Code

It's currently on:
tests\ArraydotifyText.php:8-32
tests\ArraydotifyTest.php:8-32

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Console\Command.php:139-158
src\Console\Command.php:439-460

CodeFactor found an issue: Empty return statement not required here

It's currently on:
src\Application\Application.php:551

• Version: 3.1.5
• PHP Version: 7.2.10
• Database Driver & Version: Mysql|Sqlite

Description:

When i add Engine to the view system raide an error. This is occur when de Engine is not valid.

Steps To Reproduce:

View::pushEngine('twig', IsNotAvailableClass::class);

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Router\Route.php:9-151
src\Application\Route.php:8-147

Description

When we use HttpClient in unity test. Cannot add the additonnals headers. Eg: add the Authenticate: Beader token is not possible.

Check this files: src/Testing/TestCase.php and src/Http/Client/HttpClient.php

Help:

curl_setopt($ch, CURLOPT_HTTPHEADER, array(
    'X-Apple-Tz: 0',
    'X-Apple-Store-Front: 143444,12'
));

• Version: 3.0.1
• PHP Version: 7.2.*
• Database Driver & Version: Mysql

Description:

When i call the rest method this error is raised.
Undefined variable $value in Rest::make method

Steps To Reproduce:

That arrived when i do this:
In this router ficher

<?php

$app->rest('/todos', 'TodoController');

Description:

@papac , this is about Travis CI build on specific branches.

I think it doesn't make sense to let this repository run Travis CI build only on master branch.

We should make sure repository on active branch should be worked/passed in Travis CI build successfully.

My suggested solutions are as follows:

• Remove master branch only definition in Travis CI build. Make all current branches running CI build.
• Keep mater branch only existed and add other branches with regular expression in .travis.yml setting.

I prefer first solution because it can make sure all oncoming branches (including branches are from PRs)
can be passed/worked in Travis CI build.

References

• https://docs.travis-ci.com/user/customizing-the-build#using-regular-expressions

Description

The HttpClient agent cannot process greatly the url who respect this partern https://exemple.com/api?name=peter papac.

There are always error in the response parsing.

CodeFactor found an issue: Variable assignment found within a condition. Did you mean to do a comparison ?

It's currently on:
src\Console\Command.php:337

Description:

@papac . This is about Enhance Bow\Security\Crypto class enhancement.

I've found that this class uses openssl to do encryption and decryption works.

It's not good because the sodium is available since the php-7.x versions are released.

I recommend we should change the openssl encryption/decryption to sodium.

It would be better than openssl because of modern Cryptography security :).

References

• https://www.php.net/manual/en/book.sodium.php
• https://www.futurehosting.com/blog/php-7-2-to-integrate-libsodium-a-powerful-modern-cryptographic-library/
• https://blog.zend.com/2018/11/06/modern-cryptography-in-php-7-2-with-sodium/#.XQHrbo9-WuU

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Console\Command.php:59-131
src\Console\Command.php:325-402

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Testing\Behavior.php:40-109
src\Testing\Behavior.php:63-199

CodeFactor found an issue: Comment refers to a TODO task "Implement prepend() method"

It's currently on:
src\Resource\AWS\AwsS3Client.php:164

CodeFactor found an issue: Comment refers to a TODO task "Implement makeDirectory() method"

It's currently on:
src\Resource\AWS\AwsS3Client.php:188

It would be great to have a roadmap to know what this framework is aiming for.

CodeFactor found an issue: Variable assignment found within a condition. Did you mean to do a comparison ?

It's currently on:
src\Http\Request.php:97

• Version: 3.0.3
• PHP Version: 7.2

Description:

Middleware additionnal parameters is merge with middleware alias name.

Steps To Reproduce:

$app->get()->middleware('api:guest')

CodeFactor found an issue: Variable assignment found within a condition. Did you mean to do a comparison ?

It's currently on:
src\Support\Console\Command.php:69

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Console\Command.php:709-728
src\Support\Console\Command.php:356-373

Integration of great error management system for all available packages in the framework base on:

try {} catch ($e) {}

• Version: 3.0.3
• PHP Version: 7.2

Description:

Undefined index: middeware in Bow\Application\Application::route

        ...
        if (isset($cb['middleware'])) {
            unset($cb['middleware']);
        }
 
        if (isset($cb['controller'])) {
            unset($cb['controller']);
        }
 
        $route = $this->pushHttpVerbe($method, $path, $cb);
 
        if (isset($definition['middleware'])) {
            $route->middleware($definition['middeware']);
        }
 
        $route->where($where);
    }

Steps To Reproduce:

when i call $app->route() in a apply middleware option with ['middleware' => 'guest']

Description:

The sudo setting in .travis.yml setting is deprecated.

And the user is not root by default.

The detailed reference is available here.

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Console\Command.php:537-558
src\Support\Console\Command.php:223-242

CodeFactor found an issue: Empty return statement not required here

It's currently on:
src\Console\Bow.php:357

• Version: master

Description:

It's about the Travis CI build.

The vipconsult/proftp Docker image has been problematic because it will present docker: Error response from daemon: invalid mode: /etc/proftpd/ftpd.passwd when running Docker image as container.

We can look at this Travis CI build log to know detailed situation.

As we can look at log, I remove -d from the docker run --net=host --name proftpd -v $(pwd)/:/home/$FTP_USER vipconsult/proftpd command.

It will present chown: cannot access '/etc/proftpd/ftpd.passwd': No such file or directory message.

Suggested solution

• I think we can use other FTP server Docker images instead.

@papac, do you have any idea about other Docker images about FTP server?

• PHP Version: 7.2.*
• Database Driver & Version: Mysql|Sqlite

Description:

The migration class name is incorrect, 20181018080355Test

<?php

use Bow\Database\Migration\Schema;
use Bow\Database\Migration\Migration;
use Bow\Database\Migration\TablePrinter as Printer;

class 20181018080355Test extends Migration
{
    /**
     * create Table
     */
    public function up()
    {
        Schema::create("table", function(Printer $table) {
            //
        });
    }

    /**
     * Drop Table
     */
    public function down()
    {
        Schema::dropIfExists("table");
    }
}

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Support\Console\Bow.php:165-184
src\Console\Bow.php:252-275

CodeFactor found an issue: Complex Code

It's currently on:
src\Support\helper.php

CodeFactor found an issue: Comment refers to a TODO task "Implement append() method"

It's currently on:
src\Resource\AWS\AwsS3Client.php:156

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Console\Command.php:300-323
src\Support\Console\Command.php:39-57

• Version: 4.0.4
• PHP Version: 7.2.0
• Database Driver & Version: Mysql

Description:

Undefined index: name in file .../vendor/bowphp/framework/src/Validation/Validator.php on line 273

Steps To Reproduce:

When we make the validation on undefined key in the validation data this error is occured.

• Tintin Version: 3.0.0
• PHP Version: 7.2

Description:

The application rest service don't work.

CodeFactor found an issue: Variable assignment found within a condition. Did you mean to do a comparison ?

It's currently on:
src\Application\Application.php:511

• Version: 3.0.2
• PHP Version: 7.2.*
• Database Driver & Version: Mysql|Sqlite

Description:

There are an error, when the translation dictionnary file do not return array and i use the service.

Steps To Reproduce:

in components/lang/fr/welcome.php

<?php
// Empty

and I use Transalor::translate('welcome.greeting').

CodeFactor found an issue: Empty return statement not required here

It's currently on:
src\Support\Console\Bow.php:237

• Version: 3.0
• Database Driver & Version: Mysql

Description:

Il n'y aucun moyen de créer des relations entre les models.

An error occurred during the tests. Due to the absence of the autoload.php file

CodeFactor found an issue: Duplicate Code

It's currently on:
src\Router\Route.php:159-332
src\Application\Route.php:161-324