Filtering conditions for bubble indicators. about lppls HOT 2 CLOSED

Thanks for getting back. I will prepare the change tonight.

from lppls.

Hi @tucaman,

Thanks for bringing this up. It appears that I am calculating the number of oscillations incorrectly. I haven't quite wrapped my head around the math but by visualizing a fit and its estimated parameters, it becomes clear that the number of oscillations identified by my current code is much less than what is represented in the plot. For example here is a single fit.

Here are the estimated parameters:

• tc: 1411.2478663672039
• m: 0.48440456637744556
• w: 9.947939150512653
• a: 5.054135495639681
• b: -0.1199213964144249
• c: 0.017175517611846273

And here are the computed number of oscillations via the old and new ways.

• old n osc: 0.022069611539656146
• new n osc: 8.58127269784443

where

• first: 0
• last: 1405

A manual count of the oscillations in the plot yields ~ 8 so I would like to merge in your proposed change.

Would you like to create a branch and I can review and merge? No worries if not, I can implement it later this week.

Best,

Josh

from lppls.