boglin / pymysql Goto Github PK

View Code? Open in Web Editor NEW

This project forked from pymysql/pymysql

0.0 2.0 0.0 987 KB

PyMySQL: Pure-Python MySQL Client

Home Page: http://www.pymysql.org/

License: MIT License

Python 100.00%

pymysql's Issues

Multi-statement init_command causes subsequent query to fail

Given that the CLIENT.MULTI_STATEMENTS flag is set, it is valid for the init_command supplied by the connection contain multiple statements. Since on one ok_packet is read this causes subsequent queries to return unexpected results since client/server are out of sync.

Demonstrated by:

    def test_init_command(self):
        conn = pymysql.connect(
            init_command='set time_zone="+00:00"; set max_join_size=1000',
            **self.databases[0]
        )
        c = conn.cursor()
        c.execute('select "foobar";')
        self.assertEqual(('foobar',), c.fetchone())
        conn.close()

Support custom mapping for connection's escape method

MySQLdb provides a second argument to connection's escape method where an 'encoders' dict can be supplied.

For compatibility with existing code could this be added to PyMySQL?

From MySQLdb, _mysql.c:

static char _mysql_escape__doc__[] =
"escape(obj, dict) -- escape any special characters in object obj\n\
using mapping dict to provide quoting functions for each type.\n\
Returns a SQL literal string.";

Proposed test case:

def test_escape_custom_object(self):
    con = self.connections[0]
    cur = con.cursor()

    class Foo(object):
        value = "bar"
        encoder = lambda x: x.value

    self.assertEqual(con.escape(Foo(), encoders={Foo: encoder}), "bar")

Recommend Projects