bodsch / ansible-container Goto Github PK

Currently, the login is only supported in one registry.

container_registry:
  host: ''
  username: ''
  password: ''

However, containers from different registries may be required.
In this case, the configuration should be extended accordingly.

Proposal:

container_registry:
  - registry: ''
    username: ''
    password: ''

Please make the extension of the configuration downward compatible!

For security reasons, I would like to start the containers in the "read_only" mode.
See https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#parameter-read_only

At present, exactly one properties file can be created:

container:
  - name: hello-world
    hostname: hello-world
    image: hello-world:latest
    properties:
      #
      publisher.maxRecursionDepth: 200
      # user and password for login to the staging serve
      replicator.user: 'replicator'
      replicator.password: 'replicator'
      # replicator.domain: ''
      replicator.tmp_dir: 'var/tmp'

Sometimes, however, it makes sense to include a set of properties files for the container - depending on the application.

Therefore, the role should be extended to support multiple files per container.

Perhaps a new variable can be used for this purpose:

container:
  - name: hello-world
    hostname: hello-world
    image: hello-world:latest
    property_file:
      - name: publisher.properties
        properties:
          #
          publisher.maxRecursionDepth: 200
          # user and password for login to the staging serve
          replicator.user: 'replicator'
          replicator.password: 'replicator'
          # replicator.domain: ''
          replicator.tmp_dir: 'var/tmp'
      - name: database.properties
        properties:
          #
          sql.storage: ...
          

@bodsch thanks for your great work!
I have a problem, with the generated "container.env" file, which looks like

# generated by ansible
-Xmx1gSPRING_BOOT_EXPLODED_APP=true

and causes the JVM to fail at startup: Invalid maximum heap size: -Xmx1gSPRING_BOOT_EXPLODED_APP=true

The inventory looks like:

environments:
  JAVA_HEAP: 1g
  SPRING_BOOT_EXPLODED_APP: "true"

The porblem seems to be the non existent line break between the entries. Can you have a look? Thx!

For larger setups with about 20 containers and correspondingly many volumes or mounts, the runtimes are very long.

The number of loops should be reduced.
As an alternative, own modules should be programmed.

For example:

docker_container:
        name: nginx
        image: nginx
        state: started
        restart_policy: always
        memory: 128M
        published_ports:
          - "8080:80"
        mounts:
          - source: /var/tmp
            target: /var/tmp
            read_only: yes

upstream doku

In a large environment, there are many containers that need to be considered during a run.
It therefore makes sense to implement a kind of filter that only targets certain containers (name, image) in order to deploy them specifically.