bndr / gopencils Goto Github PK

Write tests for library.

Imagine following case: _, r := api.Res("users", resp).Id(123).Get(). After this call resp value will be not populated, and only err returned by call will be json: Unmarshal(nil).

It's not so obvious to understand the problem.

Maybe, more clear message should be returned?

Sometimes API return error codes, and reply is not necessary even a JSON.

I mean, it should be JSON in correctly implemented REST API, but if server is uttrely broken you can get even a nginx default 404 page in the reply.

Even if reply is a JSON, it's probably incorrect to include error structures in the supposed normal reply structure to somehow output message to the user.

So, I think that non 100/200 error codes should leave body unparsed so gopencils user can parse it to the possible structure or just output it as text.

I can made PR if you agree on.

In the API constructor when no Client is provided, the default one shall define a timeout value to 10 seconds for example.

https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

PR can be provided if needed.

Posting multipart form data (with files) should be implemented.

Big disclaimer that I'm new to Go, but would love either a short example or a pointer to the appropriate JSON project that demonstrates how you consume/navigate the payload of the response. The README seems pretty clear about how to auth and construct restful urls, just looking for a pointer towards the next step. Thank you!

This library mentions it will support OAuth. Is there a specific example of just how such could be combined with gopencils?

dont mean to sounds ungrateful but i am looking for something that code generates from a restful service, so that its easier to work with and also faster.

Have you thought at all about this.

RT