This is a note, mostly for myself. FedEx is short for Federal Express, so in camelCase and anytime the F is capitalized, I'm going to capitalize the E as well. I'm not sure I've been doing it consistently, but I think it should be FedExSomething, fedExSomething, fedex_something, but never FedexSomething. I'm going to go with that from now on, and fix any previous mistakes as I go.

Spoke with bojanz in Slack recently and he provided some feedback on the module.

One of the things he said was that we should get rid of the service since we're only using it in one place, and just put that code directly in the FedEx plugin.

I initially didn't want to bloat that plugin with connection details and wanted to abstract whatever's providing the FedEx objects for use, however I can see his point--a service isn't really necessary if this is the only place we're going to need to access it.

Currently an issue @mdlutz24 and I have both been working on a bit. Just calling it out here so we can track it.

Products need configurable "traits" such as Hazardous that will change the behavior of shipping calculation.

Currently @mdlutz24 is working on this feature.

when trying to add a new shipping method and Fedex is installed i get a 500 error & this message in the drupal logs:

TypeError: Argument 2 passed to Drupal\Component\Plugin\PluginManagerBase::createInstance() must be of the type array, null given, called in .../modules/contrib/commerce/src/Plugin/Field/FieldType/PluginItem.php on line 131

on a non PHP7 server there was a type hint causing some issues. patch provided

to_account_for_php_LT7_remove_scalar_type_hint2.txt