blue-chip-js / blue-chip Goto Github PK

According to the JSON API spec a an empty to-one relationship is represented by {data: null}. But blue-chip doesn't currently handle this, resulting in a null is not an object error:

The .includes() feature only works if the resource name is the same as the resource type (optionally pluralized), e.g.:

relationships: {
  user: {data: {id: 8, type: "users"}}
}

But there is nothing in the spec AFAIK that requires that, so this is also valid:

relationships: {
  reviewer: {data: {id: 8, type: "users"}}
}

But blue-chip will not find that relationship. I haven't dug into the code yet to determine what this will require, but this ought to be supported, right?

I'm encountering an issue when trying to install @blue-chip/core which has a dependency on graphql-normalizr. The build process for graphql-normalizr fails with the error 'BABEL_ENV' is not recognized as an internal or external command.

Steps to Reproduce:

1. Run npm i -S @blue-chip/core in my project directory.

2. Encounter the following error during the installation process:

   npm ERR! > [email protected] prepare
   npm ERR! > npm run clean && npm run build
   ...
   npm ERR! > [email protected] build:cjs
   npm ERR! > BABEL_ENV=cjs babel src --out-dir lib
   npm ERR! 'BABEL_ENV' is not recognized as an internal or external command,
   npm ERR! operable program or batch file.
   

Expected Behavior:
I expect the installation process to complete successfully without any errors.

Environment:

• OS: Windows 10
• Node.js version: 21.7.1
• graphql-normalizr version: 1.0.2

Additional Context:
I've tried setting the BABEL_ENV environment variable in the package.json file using cross-env, but the issue persists. Any assistance in resolving this would be greatly appreciated.

Slightly similar to #28, if a query is made against a resource store that contains no matches, and that query has a .whereRelated, it will fail (v0.3.4, screenshot from Safari):

Prefixing a this.currentResource && check before checking Object.values() seems to do the trick, but I might be overlooking a better way to do it?

We should enable testing on CI (Travis CI, CircleCI, AppVeyor).