blinksh / mosh Goto Github PK

To make mosh multithreaded I had to transform all of the static variables into per thread ones. I used to routes to do this, using POSIX thread variables as much as I could as it is compatible with more iOS versions. Unfortunately some of them couldn't be done in this way and where triggered at the compiler level with __thread.

It would be great to remove this two implementations and either go with one for everything, or even better, fix mosh from the root.

I thought the reason why no one supports [email protected] and [email protected] in iOS are because essentially everyone is using libssh2, due to license reasons. I've read that libssh being LGPL cannot be statically linked, and AAPL mandates static linking.

Is this not true? If not, could blink from license POV use libssh? If this is true, how is GPL 3.0 licensed mosh possible?

Should affect Xcode 9.X generally. The error occurs on line 88 of src/frontend/iosclient.cc (int unused __attribute((unused)) = system( "locale" );).

A quick workaround is to just comment out the line -- its apparent purpose is to output locale information to the user, in case the locale is not UTF-8 native.

I was able to build and run the blink shell successfully under iOS 11.2.2 after making the above change, but I have not tested the mosh functionality yet (ssh works fine).

Keep up the great work on this awesome project! :-)