Giter Club home page Giter Club logo

blacksmithing's People

Watchers

avatar

blacksmithing's Issues

Durability gained

Hello,

The Durability gained from blacksmith levels appears to not increase max durability, only the initial durability.

Installed Extended Item Data Framework mod from Randy (which is not listed as dependency nor does it seem to be required by Blacksmithing) fixes this.

If EIDF is supposed to be required/needed it isn't listed as so on the modpage through the Thunderstore

Updating Item Durability on Repair or Upgrade

Hi! Would it be possible to update existing item durability stats to the current blacksmithing skill level when the item is repaired/upgraded?

Current mechanics encourage making a bunch of duplicate/cheap items to level up the skill before making the actual item you want, as otherwise you can't take advantage of the durability bonus.

One way to implement this in a somewhat balanced way is to initially update durability only when the item is upgraded, and then when the item is max-level the durability updates upon repair.

Error with Hildr update

Hi, if you could have a look, this mod seems broken atm (even though you've updated it for the update) :

[Error  : Unity Log] InvalidOperationException: Sequence contains no matching element
Stack trace:
System.Linq.Enumerable.First[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) (at <351e49e2a5bf4fd6beabb458ce2255f3>:0)
MonoMod.Utils.DynamicMethodDefinition+<>c__DisplayClass3_0.<_CopyMethodToDefinition>g__ResolveTokenAs|1 (System.Int32 token, MonoMod.Utils.DynamicMethodDefinition+TokenResolutionMode resolveMode) (at <6733e342b5b549bba815373898724469>:0)
MonoMod.Utils.DynamicMethodDefinition+<>c__DisplayClass3_0.<_CopyMethodToDefinition>g__ReadOperand|0 (System.IO.BinaryReader reader, Mono.Cecil.Cil.Instruction instr) (at <6733e342b5b549bba815373898724469>:0)
MonoMod.Utils.DynamicMethodDefinition._CopyMethodToDefinition () (at <6733e342b5b549bba815373898724469>:0)
MonoMod.Utils.DynamicMethodDefinition.Reload () (at <6733e342b5b549bba815373898724469>:0)
MonoMod.Utils.DynamicMethodDefinition..ctor (System.Reflection.MethodBase method) (at <6733e342b5b549bba815373898724469>:0)
(wrapper dynamic-method) MonoMod.RuntimeDetour.ILHook+Context.DMD<MonoMod.RuntimeDetour.ILHook+Context::Refresh>(MonoMod.RuntimeDetour.ILHook/Context)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<MonoMod.RuntimeDetour.ILHook+Context::Refresh>?-1714788352(object)
HarmonyLib.Internal.RuntimeFixes.StackTraceFixes.OnILChainRefresh (System.Object self) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
MonoMod.RuntimeDetour.ILHook.Apply () (at <4e2760c7517c4ea79c633d67e84b319f>:0)
HarmonyLib.Public.Patching.ManagedMethodPatcher.DetourTo (System.Reflection.MethodBase replacement) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
Rethrow as HarmonyException: IL Compile Error (unknown location)
HarmonyLib.Public.Patching.ManagedMethodPatcher.DetourTo (System.Reflection.MethodBase replacement) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
Rethrow as HarmonyException: IL Compile Error (unknown location)
HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.PatchProcessor.Patch () (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.Harmony.Patch (System.Reflection.MethodBase original, HarmonyLib.HarmonyMethod prefix, HarmonyLib.HarmonyMethod postfix, HarmonyLib.HarmonyMethod transpiler, HarmonyLib.HarmonyMethod finalizer, HarmonyLib.HarmonyMethod ilmanipulator) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
Blacksmithing.Blacksmithing.ApplyTranspilerToAll (System.Collections.Generic.List`1[T] methods, System.Reflection.MethodInfo transpiler) (at <1c825171d85a4c94ae84f7c1137140b0>:0)
Blacksmithing.Blacksmithing+IncreaseCraftingSkill.Postfix () (at <1c825171d85a4c94ae84f7c1137140b0>:0)
(wrapper dynamic-method) FejdStartup.DMD<FejdStartup::Awake>(FejdStartup)

No loger generating config file

Noticed that the increased durability was no longer recognized in-game, as if the mod had been uninstalled. Deleted config files and reinstalled/launched game. No new config files were generated, game continues to run but does not change to add the blacksmithing skill.

Incompatibility with Valheim Plus

Hello Smoothbrain,

unfortunately many of your mods are incompatible with Valheim Plus.

Did you add this incompatibility to prevent issues?

For Blacksmith for example Valheim Plus also has the config to change weapon durability, but on default it is turned off.
Same goes for Foraging/ Farming - yield of crops.

Thank you
Squall

Mod not working at all.

Added the mod via thunderstore but it's not working. It's enabled on my server and client but it's done nothing, no config file or anything.

Missing Blacksmithing Skill

While using 1.2.2 I have Blacksmithing skill missing, the perks aren't working.
While using 1.2.0 Skill is back visible and working.

Here's my profile code for debug?
0185bb5e-278f-a92f-6508-5ea358f32e57

Mistlands Black Forge and Galdr Table

This is a bit more of a question then an issue. So I see when I hit level 50 in blacksmith it added a level to the forge and the workbench, will this effect the Black Forge and Galdr Table at all or do I need to be level 80??

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.