Giter Club home page Giter Club logo

Comments (1)

WhileE avatar WhileE commented on July 17, 2024

It looks like if I swap the order add_price_event() and add_bar_event(), things work better.

Digging into the code a bit, it initially looks like the final_prices are getting squashed here:

(BacktestController.py, line 418)

if len(relevant_data) > 0:
    final_prices[symbol] = pd.concat(relevant_data)

My initial testing shows that the following code preserves all prices @ all resolutions:

if len(relevant_data) > 0:
    if symbol not in final_prices:
        final_prices[symbol] = pd.concat(relevant_data)
    else:
        new_data = pd.concat(relevant_data)
        final_prices[symbol] = pd.concat([final_prices[symbol], new_data])

I'm not super familiar with enough of the code to understand what impact this could cause, but if there are tests I can run against it just let me know. Going to keep testing to see if it breaks anything else that I can see.

from blankly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.