Giter Club home page Giter Club logo

sqlx-adapter's People

Contributors

blank-xu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

sqlx-adapter's Issues

Tests fail with latest Casbin 2.65.0

Some tests fail when running against the latest Casbin version, e.g.,

 adapter_test.go:369: Policy: 
         [] , supposed to be 
         [[bob data1 write test1 test2 test3]]

It seems that Casbin logic around Tokens in the model changed.

UpdateFilteredPolicies doesn't work with the latest Casbin version 2.65.0

The returned oldPolicies from UpdateFilteredPolicies may contain empty strings for some V columns. It seems, the latest Casbin doesn't like that:

func (model Model) RemovePoliciesWithAffected(sec string, ptype string, rules [][]string) [][]string {
	var affected [][]string
	for _, rule := range rules {
		index, ok := model[sec][ptype].PolicyMap[strings.Join(rule, DefaultSep)]
		if !ok {
			continue
		}

The index, ok := model[sec][ptype].PolicyMap[strings.Join(rule, DefaultSep)] is the problem.

The following workaround works for me:

func (p *Adapter) UpdateFilteredPolicies(sec, ptype string, newPolicies [][]string, fieldIndex int, fieldValues ...string) (oldPolicies [][]string, err error) {

// omitted some lines

        oldPolicies = make([][]string, 0, len(oldRows))
	for _, rule := range oldRows {
		var oldPolicy []string
		sliceRule := append([]string{}, rule.PType, rule.V0, rule.V1, rule.V2, rule.V3, rule.V4, rule.V5)
		for _, v := range sliceRule {
			if v == "" {
				continue
			}
			oldPolicy = append(oldPolicy, v)
		}
		oldPolicies = append(oldPolicies, oldPolicy)
	}

// omitted some lines

}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.