bitpay / bitcore-build Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 165.0 181 KB

A helper to add tasks to gulp

JavaScript 100.00%

bitcore-build's Introduction

BitPay Perl Client

Business::BitPay - BitPay API

Quick Start

See the guide.

DESCRIPTION

BitPay API documentation contents full description of API methods: https://bitpay.com/help-api.

AUTHOR

Sergey Zasenko, [email protected]

COPYRIGHT AND LICENSE

This program is free software, you can redistribute it and/or modify it under the same terms as Perl 5.10.

bitcore-build's People

Contributors

Stargazers

Watchers

bitcore-build's Issues

Test module

https://github.com/gulpjs/gulp/blob/master/docs/writing-a-plugin/testing.md

Drop the releases branch

I think there's no actual reason why it needs to be there.

We could have a tag/branch called "current" to signify what's the latest release, but the current schema of "having a branch with merge commits between the last build commit (the ones with the binaries) and the current master be the next release commit" I feel that has no use case or reason to be kept.

Bumper for npm-shrinkwrap.json

Currently bumping the version in npm-shrinkwrap.json needs to be done manually.

Commit message is off for minor updates.

Commit Message shows "Bump package version to 0.10.3"
package.json shows "0.11.0"

bitpay/bitcore-p2p@df632f3

bower.json version

It may be unnecessary to include the version number in bower.json, see: bitpay/bitcore#1272

uglify mangles object names that bitcore requires

I'm using bitcore 0.8.5 from bower.

Using the minified brower bundle, several bitcore functions fail because they expect arguments to be of a certain type, which uglify has mangled to a single letter name.

For example
https://github.com/bitpay/bitcore/blob/master/lib/address.js#L231

  if (!(pubkey instanceof PublicKey)) {
    throw new TypeError('Address must be an instance of PublicKey.');
  }

but PublicKey has been mangled to a single letter and I get the following error:

 TypeError: Address must be an instance of PublicKey.
    at Function.n._transformPublicKey (http://localhost:9000/bower_components/bitcore/browser/bitcore.min.js:1:5708)
    at Function.n.fromPublicKey (http://localhost:9000/bower_components/bitcore/browser/bitcore.min.js:1:6453)
    at l.d.toAddress (http://localhost:9000/bower_components/bitcore/browser/bitcore.min.js:4:4457)

npm v3 support

npm@3 install modules maximally flat and browserify can be installed on same level as bitcore-build and path to binary should be (for npm@3)

./node_modules/.bin/browserify

instead

./node_modules/bitcore-build/node_modules/.bin/browserify

full error message:

$ gulp test:browser
[16:12:47] Using gulpfile ~/work/bitcore-lib/gulpfile.js
[16:12:47] Starting 'browser:uncompressed'...
[16:12:47] Starting 'browser:maketests'...
/bin/sh: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory
[16:12:47] 'browser:uncompressed' errored after 39 ms
[16:12:47] Error in plugin 'gulp-shell'
Message:
    Command failed: /bin/sh -c ./node_modules/bitcore-build/node_modules/.bin/browserify --require ./index.js:bitcore-lib -o bitcore-lib.js
/bin/sh: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory

Details:
    killed: false
    code: 127
    signal: null
    cmd: /bin/sh -c ./node_modules/bitcore-build/node_modules/.bin/browserify --require ./index.js:bitcore-lib -o bitcore-lib.js
    stdout: 
    stderr: /bin/sh: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory

xargs: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory
[16:12:47] 'browser:maketests' errored after 26 ms
[16:12:47] Error in plugin 'gulp-shell'
Message:
    Command failed: /bin/sh -c find test/ -type f -name "*.js" | xargs ./node_modules/bitcore-build/node_modules/.bin/browserify -t brfs -o tests.js
xargs: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory

Details:
    killed: false
    code: 127
    signal: null
    cmd: /bin/sh -c find test/ -type f -name "*.js" | xargs ./node_modules/bitcore-build/node_modules/.bin/browserify -t brfs -o tests.js
    stdout: 
    stderr: xargs: ./node_modules/bitcore-build/node_modules/.bin/browserify: No such file or directory