biter777 / countries Goto Github PK

As of December 2021, Turkey was renamed to Türkiye (full, Republic of Türkiye). This change has been recognised and adopted by the UN, WTO and NATO as of July 2022 [cite] [cite] and US State Department as of January 2023 [cite].

It would be great if the package could be updated to reflect this change.

Current name resolution

Vulnerabilities

DepShield reports that this application's usage of golang.org/x:crypto:0.0.0-20190308221718-c2843e01d9a2 results in the following vulnerability(s):

• (CVSS 5.9) [CVE-2019-11840] Use of Insufficiently Random Values

Occurrences

golang.org/x:crypto:0.0.0-20190308221718-c2843e01d9a2 is a transitive dependency introduced by the following direct dependency(s):

• github.com/jinzhu:gorm:1.9.12
        └─ golang.org/x:crypto:0.0.0-20191205180655-e7c4368fe9dd
              └─ golang.org/x:net:0.0.0-20190404232315-eb5bcb51f2a3
                    └─ golang.org/x:crypto:0.0.0-20190308221718-c2843e01d9a2

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

The value 986 is for currency, not for country. The Country code of BRASIL is 076 or 76. Can you fix it?

I did some work and created following pull request: #16

Hope it helps.

I am missing native names when I want to provide users with options to pick their country. It's all in English which does not make sense in certain situations.

So for example:
Hungary -> Magyarország
Slovakia -> Slovensko
Czechia -> Česko
Austria -> Österreich
Spain -> España
Russia -> Россия
Bulgaria -> България
China -> 中國

and so on.

I am unable to verify a country by using just herIOC/NOC code

Hi, thank you for this awesome software!

I noticed that some call codes do not match google's libphonenumber, for example:

Are these code correct?

const (
	// RegionAfrica       RegionCode = 2
	RegionAfrica RegionCode = 2
	// RegionNorthAmerica RegionCode = 3
	RegionNorthAmerica RegionCode = 3
	// RegionSouthAmerica RegionCode = 5
	RegionSouthAmerica RegionCode = 5
	// RegionOceania      RegionCode = 9
	RegionOceania RegionCode = 9
	// RegionAntarctica   RegionCode = 999
	RegionAntarctica RegionCode = 999
	// RegionAsia         RegionCode = 142
	RegionAsia RegionCode = 142
	// RegionEurope       RegionCode = 150
	RegionEurope RegionCode = 150
)

It seems to me that North America and South America codes are wrong.
See here.

https://en.wikipedia.org/wiki/ISO_3166-2:BD & https://en.wikipedia.org/wiki/Mymensingh_Division

The new division was established in 2015.

Happy to PR :)

HI!
Thanks for the project, this is awesome work!

I found a bug in my project when using it in production environment, that the Chilean currency is Chilean Peso (CLP) instead of Chilean Unidad de Fomento (CLF).

I hope this bug will be fixed soon.

hello,

Building off an earlier issue (#5),
Apple denotes Kosovo as XKS instead of using XKX in its In-App-Purchase libraries; would it be possible to include that in the country list?
I can create a PR from my fork: master...hfkang:countries:AddKosovo_XKS

thanks!

HI!
Thanks for the project, this is awesome work!

I'm using your library to import geolocation data and need the official languages by a country.

To solve that, I'm building a list of country codes and languages.

WDYT about put this info inside the library? If ok for you I can open a PR for these.

Could you please use 'v1.4.0' for your tags? Go mod can't properly vendor tags like '1.4.0', it needs 'v' in the beginning.
Thanks!

AFG','BHR','BGD','BRN' add above country codes and respective country related details if missing

Depshield will be deprecated on Monday December 12th

Please install our new product, Sonatype Lift with advanced features

MACEDONIA, THE FORMER YUGOSLAV REPUBLIC OF => North Macedonia
VENEZUELA, BOLIVARIAN REPUBLIC OF => Venezuela
MOLDOVA, REPUBLIC OF => Moldova
TAIWAN, PROVINCE OF CHINA =>Taiwan
PALESTINIAN TERRITORY, OCCUPIED => Palestine

This may be a bit of a nitpick but, according to my understand, the United States has two currency codes associated with it: US dollar (USD) and US dollar, next day (USN). Why is it that calling countries.UnitedStatesOfAmerica.Info().Currency.Alpha() returns USN rather than USD when USD would be the more idiomatic usage? My use case for this code-base is primarily getting the 2-character country code and currency combinations associated with each for internationalization purposes but this doesn't seem fit-for-purpose. Perhaps split the US entry into two entries would fix this issue?

Note: I can get around this by taking the country code and doing countries.CurrencyCode(code) to get the proper code and if this is the intended usage when there is a collision then I would appreciate a function that does that explicitly.

First of all, thank you for this amazing package! You've saved me a TON of work.

One call out I have is, this package doesn't seem to implement the database/sql/driver.Valuer and database/sql/driver.Valuer interfaces for SubdivisionCode.

How I arrived at this conclusion:
I have an API that takes in POST requests from the client, marshals it into a Go struct, then uses Gorm to store that struct model in a Postgres DB.
The struct has a field of type countries.SubdivisionCode, and the package is able to correctly unmarshal it into the struct as a string (i.e. "US-MA" --> "Massachusetts"). It also correctly inserts it into the DB as "Massachusetts." However, when I select that record from the DB and unmarshal it into a Go struct, the subdivision code field reads as "Unknown".

✅ POST request:

✅ Unmarshal the Request Body with Fiber into a Struct:

✅ Insert Into the DB:

❌ Select that Record from DB: Now the field shows up as Unknown.

On a related note, what function is causing "US-MA" to be read in as "Massachusetts" and when is that function called? Is there a way to insert it into the DB as a "US-MA"?

EDIT:
Using fmt.Printf("%+v") printed the field as "Massachusetts" (I'm guessing the package uses the String() method to do so), but when I just use fmt.Printf("%#v"), it outputs as "US-MA". Still, how is it getting inserted into the DB as "Massachusetts" when it doesn't have an explicit driver.Valuer function?

Vulnerabilities

DepShield reports that this application's usage of golang.org/x:crypto:0.0.0-20190325154230-a5d413f7728c results in the following vulnerability(s):

• (CVSS 5.9) [CVE-2019-11841] Cryptographic Issues

Occurrences

golang.org/x:crypto:0.0.0-20190325154230-a5d413f7728c is a transitive dependency introduced by the following direct dependency(s):

• github.com/jinzhu:gorm:1.9.12
        └─ github.com/denisenkom:go-mssqldb:0.0.0-20191124224453-732737034ffd
              └─ golang.org/x:crypto:0.0.0-20190325154230-a5d413f7728c

_{This is an automated GitHub Issue created by Sonatype DepShield. Details on managing GitHub Apps, including DepShield, are available for personal and organization accounts. Please submit questions or feedback about DepShield to the Sonatype DepShield Community.}

Is there a way to convert ISO-3166-1 alpha3 country codes to alpha2? I.e. "AUT" to "AT".

I'm using the no longer maintained project

https://github.com/launchdarkly/go-country-codes

which has the GetByAlpha3() method, which I'm missing here.

Thanks.

Any way to look up a country based on a known alpha3 country code?

The following files have the Sudan code set to 736

Per the ISO standard this should be 729

Hi 👋

I suggest to add the temporary country codes for Kosovo. There is no ISO code yet but some organisations already use XK and XKX.

I've added it in my fork: https://github.com/benja-M-1/countries/tree/patch-kosovo.
I can submit a PR if you are ok with that. (unfortunately there is an issue with the formatting and git was unable to make a correct diff)

Hi,

It seems that countries.AllInfo() returns GB two times.

list := countries.AllInfo()

for i, c := range list {
     fmt.Println(i, c.Alpha2)
}

Result

38 GB
...
230 GB

Ref:

• https://en.wikipedia.org/wiki/ISO_3166-2
• https://www.iso.org/standard/72483.html
• https://salsa.debian.org/iso-codes-team/iso-codes

How shell I reference the latest releases from external project?

In this repo the module name was changed ea14952 but the other repository https://github.com/royshahaf/countries last commit is from February and there is no way to reference the recent changes any way.

in go.mod

require (
	github.com/biter777/countries v1.3.4 <- This is the last working version
	github.com/royshahaf/countries v1.5.1 <- This repo has only github.com/royshahaf/countries v1.3.7

Now Go can't find the right module and the right repository.

go: github.com/biter777/[email protected]: parsing go.mod:
        module declares its path as: github.com/royshahaf/countries
                but was required as: github.com/biter777/countries

The two only working version now are

• github.com/biter777/countries v1.3.4
• github.com/royshahaf/countries v1.3.7

Either fix the module names or please update the repository so the v1.5.x can be referenced from externally.

I like to use this lib, soo when I started to test for Brazil, I got a problem because the lib just accept the code 76 for Brazil currency. But as we can see at https://pt.wikipedia.org/wiki/ISO_4217, the code 76 is for a very old Brazil currency named as Cruzeiro that is no longer valid since 30 years ago. The correct Brazil code is 986 for currency named as Real.

I created a PR for this fix, I would like if the maintainer could review :)
#39

Thanks for your work on this!

We're noticing that countries.ByName("CZE") is returning Czech Republic here. The general pattern seem to be that we return the name as opposed to official_name from here in which case it seems like it should be Czechia, unless I'm missing something. Happy to submit a pr to resolve if this is not intentional.

Hi 👋

I tried this package and found an issue here: https://github.com/biter777/countries/blob/master/countries.go#L5296
Go panics with this message: "error parsing regexp: missing argument to repetition operator: +"

You can try it here https://play.golang.org/p/dc98B-UIn7p

I don't know how to fix, if you provide me sufficient information I could make a PR. Locally I only removed the "+" from the string but I guess it was useful :/

I notice you have a data file for ISO-3166-3, but I can't (for example) find SU. Are you planning on supporting these?

I think its called North Macedonia now