bisq-network / bisq-markets Goto Github PK

It seems like the website is not showing all offers on the Dash network.
I can see 2 DASH/EUR offers in my Bisq client that are not displayed on the website.

I'm not sure if this is a real issue or if I'm doing some mistakes.

The verification of the GET response using R console shows that the response content is not json:

bisq.response <- GET("https://markets.bisq.network/api/markets")
http_type(bisq.response)
[1] "text/html"

I did the same (basic) test to the github API to check if I'm doing something wrong:

github.response <- GET("https://api.github.com/repos/bisq-network/bisq-desktop")
http_type(github.response)
[1] "application/json"

The Firefox browser shows the same issue:

https://markets.bisq.network/api/volumes?basecurrency=btc&milliseconds=true&timestamp=no&fillgaps=&interval=day

[Expected Result, i.e. when risq returns 200]

[
  {
    "volume": "1.39170000",
    "num_trades": 4,
    "period_start": "2016-04-19T00:00:00+00:00"
  },

[Actual Result, i.e. when risq returns 503]

{
  "data": {
    "volumes": [
      {
        "period_start": "1461024000",
        "periodStartDateTime": "2016-04-19T00:00:00+00:00",
        "volume": "1.39170000",
        "num_trades": 4.0
      },

@dan-da I just recognized that I get on a couple of API calls HTTP 500 back. Could you please have a look what is going wrong? Thanks!

@memetat commented on Thu Jan 05 2017

I guess this is paranoia, but could the amounts in fiat reported on market.bitsquare.io somehow not display true exact amounts, obfuscate by slightly changing exact figure slightly up/down of true value. Banks could check this data and match transactions to bitsquare usage?

@ManfredKarrer commented on Fri Jan 13 2017

Yes good point. We will consider it. Maybe just remove the cent amounts...

@dan-da commented on Mon Feb 13 2017

I think it would be a false sense of security through obscurity.

The information is already public. All that market.bitsquare.io does is display the data that the bitsquare app provides. Anyone, including other websites or banks themselves can do this...

For that matter, banks could just run the app and see trade amounts in there also.

BTX Bitcore is added to Bisq version 0.7.0. https://github.com/bisq-network/bisq-desktop/releases
But not showing up in the Currency Menue list at markets section on Bisq homepage.

If one closes a session of BISQ with open bids and offers removing the bids/offers from the market, and subsequently reopens BISQ and automatically reposts the bids and offers, the Markets tab drop-down menu does not update with the new bid/offer count until one clicks away from the Markets tab and comes back to reload the drop-down menu.

Tor Browser tries to redirect me to the onion markets site:

http://bisqmktse2cabavbr2xjq7xw3h6g5ottemo5rolfcwt6aly6tp5fdryd.onion/

But it seems down? Clearnet version works fine.

@cryptoqween commented on Mon Jan 08 2018

Hi guys,

we have integrated with you on cryptocompare.com and getting connection timeout from our server, when calling https://markets.bisq.network/api/trades/?market=btc_eur
Is it possible that our IP is blocked? Can you please let me know who I can contact about this?

Thanks guys
Quynh

@ManfredKarrer commented on Mon Jan 08 2018

@dan-da Could you have a look?

@dan-da commented on Tue Jan 09 2018

hi @cryptoqween. At present, if your site/bot is issuing more than 180 http requests per minute then the IP will be blocked for 1200 seconds (20 minutes). If this happens repeatedly, then it will be blocked for longer and longer time periods. If you would like to send me your IP, I can check if this happened. Anyway, please try to limit your request frequency as much as possible... eg only a few requests per minute. The server is not so beefy and the API backend is not fully optimized.

Another possibility for timeouts could be that the server is overloaded at certain times by too many requests. @ManfredKarrer An improvement we could make is to install cacti or similar load monitoring tool to easily check server load graphs over time. With increasing API and website load, we are bound to run into hardware limits sooner or later, and best to keep an eye on it. Other ways to scale include moving api to another domain/server eg api.markets.bisq.network and optimizing software further. Lowest hanging fruit there should be to re-enable/fix the inter-request caching that for some reason didn't work on that server when deployed.

@cryptoqween commented on Tue Jan 09 2018

Hi @dan-da thanks for the quick response, we'll descrease calls on our side and see what happens

@cryptoqween commented on Tue Jan 09 2018

Is there a way to send you a private message please? @dan-da
Thanks!

@dan-da commented on Tue Jan 09 2018

@cryptoqween github doesn't seem to support PMs. If you'd like to post an email addr I will contact you there.

@cryptoqween commented on Tue Jan 09 2018

Can you email me at q at cryptocompare dot come
Thanks @dan-da

The dan-da/bitsquare_markets repository was moved here to bisq-network/markets with bisq-network/dao#30, but the live https://markets.bisq.network site is still serving the contents of the old repository.

If @dan-da chooses to fill the role of Markets Website+API Operator/Maintainer (bisq-network/roles#9), then we can continue using his existing hosting infrastructure, and do little more than update the Git remote that the live site is being served from. If not, we'll want to stand up the markets app on new hosting infrastructure under (probably @cbeams's Heroku account) until we transition this role to a new owner.

Reported via https://twitter.com/clashicly/status/952502376723869696:

• /api/trades
• /api/offers
• /api/depth

All return either one of these messages when requesting a result via jquery's get.json:

.getJSON(jsonUrl+'&callback=?', function (data)

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://markets.bisq.network/api/volumes?basecurrency=BTC&milliseconds=true&timestamp=no&interval=minute&timestamp_from=&timestamp_to=&format=jscallback&fillgaps=&callback=jQuery331036382736050173126_1539448963683&callback=?&_=1539448963684 with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.

AND

Failed to load https://markets.bisq.network/api/trades?market=all&format=jscallback&callback=?: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4000' is therefore not allowed access.

PPI, KOTO, SUEZ, RIN, WMCC, MAZA not showing up in API trades results

https://markets.bisq.network/api/ API uses/shows older version currency list.
Is there anything I can do to help correct this?

@ripcurlx commented on Wed Mar 07 2018

To make it easier to evaluate trades by payment methods it would be great to add this field to the trades API.

@cbeams commented on Wed Mar 07 2018

This should probably go in https://github.com/bisq-network/markets, since that's where the work would actually be done.

https://markets.bisq.network/ is often down those last days

We got complaints from users on the slack, and myself monitoring https://markets.bisq.network
get a lot of alert messages
2019-07-17 06:45:08 ; https://markets.bisq.network ; _ssl.c:704: The handshake operation timed out
2019-07-17 07:00:07 ; https://markets.bisq.network ; timed out

Maybe there is some memory leak ? need to restart ?

Ping @dan-da

For example this coin https://bisq.network/markets/?currency=xrc_btc had successful trades, also has offers but you can’t see it on the website