birchroad / node-jspack Goto Github PK

Hello, I wanted to know if this package works on web.

I've tried using it on node.js and it worked just fine, but when I got to use it on web, the values that were supposed to be int came as NaN.

I'm hoping this is user error but I am not getting expected results trying to pack a signed long (8 byte integer), my test case value is 579. From the documentation, I assume 'q' is the correct format, and I'm working in Big Endian. My "other" program gives me [0, 0, 0, 0, 0, 0, 2, 67]. using 'i', 'I', 'l' and 'L' I get [0, 0, 2, 67] as expected, however using the 8 byte formats I just get zeros...

console.log("pack >i 579", jspack.Pack(">i", [579]));
console.log("pack >I 579", jspack.Pack(">I", [579]));
console.log("pack >l 579", jspack.Pack(">l", [579]));
console.log("pack >L 579", jspack.Pack(">L", [579]));
console.log("pack >q 579", jspack.Pack(">q", [579]));
console.log("pack <q 579", jspack.Pack("<q", [579]));
console.log("pack >Q 579", jspack.Pack(">Q", [579]));
console.log("pack >f 579", jspack.Pack(">f", [579]));
console.log("pack >d 579", jspack.Pack(">d", [579]));

output:

pack >i 579 (4) [0, 0, 2, 67]
pack >I 579 (4) [0, 0, 2, 67]
pack >l 579 (4) [0, 0, 2, 67]
pack >L 579 (4) [0, 0, 2, 67]
pack >q 579 (8) [0, 0, 0, 0, 0, 0, 0, 0]
pack <q 579 (8) [0, 0, 0, 0, 0, 0, 0, 0]
pack >Q 579 (8) [0, 0, 0, 0, 0, 0, 0, 0]
pack >f 579 (4) [68, 16, 192, 0]
pack >d 579 (8) [64, 130, 24, 0, 0, 0, 0, 0]

is this a bug or am i doing it wrong?

You have used the regex as
m._sPattern = '(\\d + )?([AxcbBhHsfdiIlLqQ])'
I think there shouldn't be a space in either direction of "+". I think it should be
m._sPattern = '(\\d+)?([AxcbBhHsfdiIlLqQ])';
Let me know if I am wrong

I noticed that this project is missing a few format strings that python supports - most notably, long long

I also noticed that NeoXiD has this support in his fork.
Since @NeoXiD doesn't support issues, and I saw on pgriess#2 that this fork is the one currently in npm, I was hoping you could merge @NeoXiD's changes and re-publish.

Let me know your thoughts

The library works pretty well however when i apply #6 its returning an array which i cant call toString() on properly.

The point of jspack is to have binary arrays not plain arrays.

For a string like BBBBBBBh, jspack and Python give different sizes:

FMT="BBBBBBBh"
$ node -e "console.log(require('jspack').jspack.CalcLength('$FMT'))"
9
$ python -c "import struct; print(struct.calcsize('$FMT'))"
10

Hi guys,
recently I was translating py code of "struct.pack('>q', xx)" into node, but I found jspack does not support q.
why?

'A format character may be preceded by an integral repeat count. For example, the format string "4h" means exactly the same thing as "hhhh".'

Does that mean we can use either or does it mean we have to split stuff like 4B into BBBB. @kmpm