Comments (4)
Odd. I'm going to merge your PR - I don't see any harm in it. Thanks!
from basis_universal.
If AVX || AVX2 || AVX512F are defined here then the generated SSE code won't execute on very old (ancient!) CPU's that don't support AVX. That's why these macros are here. I'll double check that this still works, though.
from basis_universal.
I've verified that SSE supports works as intended under Windows and Linux. Can you describe what you're doing that's causing these code gen sanity checks to trigger? Your options are probably not the same as the ones used to compile the tool.
I think it's fine to remove them if you're ok with the generated code not working on old CPU's. Perhaps I can put these checks in a guard.
from basis_universal.
If __AVX__ || __AVX2__ || __AVX512F__ are defined here
Those are always defined by the compiler, on CPUs that support those features.
I've verified that SSE supports works as intended under Windows and Linux.
Does that CPU support AVX? Try replicating it on a VPS, with a more modern CPU.
Can you describe what you're doing that's causing these code gen sanity checks to trigger?
Trying to enable SSE4.1 by compiling the software on a CPU that supports AVX.
See also: https://bugs.gentoo.org/892727
Your options are probably not the same as the ones used to compile the tool.
cmake -DBUILD_X64=ON -DOPENCL=ON -DSSE=ON -DZSTD=ON
if you're ok with the generated code not working on old CPU's
No such risk. Runtime CPU feature check takes care of that.
The code I'm removing with the related PR, from 2 months ago, is a redundant and buggy compile-time check. No functionality will be lost.
from basis_universal.
Related Issues (20)
- Some questions after reading some source codes
- Will OpenCL 3.0 improve compression performance? HOT 1
- How to encode HDR format resource? HOT 1
- Webssembly version does not support jpg format HOT 1
- rename HOT 2
- Selecting which transcoders to use
- Is it possible ETC1S without lossy compression ?
- RuntimeError when encoding to UASTC with WASM HOT 1
- Transcode failure on iOS 17 HOT 3
- shrinking wasm for glTF extension support HOT 1
- build_emscripen.sh script error
- Error when I cross compile for arm64 under Windows HOT 2
- Does this project with WebGPU (web)? HOT 1
- Add prefix to cmake options
- losinglena.com domain expired HOT 1
- Setup documentation to remove etc1 global codebook selector
- Compile error in cppspmd_sse.h with C++23 HOT 1
- Remove reference to etc1_global_selector_codebook from transcoder wiki page HOT 2
- Balck Textures on android HOT 11
- Question about conversion from PNG to KTX2 and BC1-7 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from basis_universal.