binarybrain / beetstream Goto Github PK

I don't know if this was a specific consequence of viewing recently added, but I installed beetstream to try it out, ran the process, pointed DSub at it. At first it seemed like it was working alright - Recently Added view rendered normally. I then installed DSub on my wife's phone and tried to repeat the same process. Responses errored, the process locked up and actually my entire server became unresponsive.

I'm guessing I triggered some kind of infinite loop. I will investigate further to see if I can get more reliable repro.

The AlbumList view is quite slow to render, stemming from the fact that the handler pulls ALL albums out of the Beets DB then does pagination in memory. For large libraries, it is very noticeable how slow this is - trying to navigate a paginated view takes forever.

Solution - we can't do pagination using built-in Beets queries, but we can should be able to use lib.transaction to perform our own SQLite query. Instead of paginating in memory we would paginate with built-in sqlite limits and offsets.