billerickson / be-events-calendar Goto Github PK

To be in line with default post types, I think the plugin should register an event post type and not events.

In the near future I'm going to working on a large project that will likely use this plugin as a base for the events system and it will be rather extensive.

If you have any feature requests or ideas (well, practical ones) please post them. When I start this project I'm going to try rolling in some new features where possible.

cc @jb510 and anyone else who uses this :)

GitHub Updater is a great solution to manage plugins that are not in the official plugin repository.

One small addition in the plugin banner should be enough to make it work:
GitHub Plugin URI: https://github.com/billerickson/BE-Events-Calendar

I would also suggest to rename the repository with lowercase letters.

Bill, I noticed that if I enable featured images and/or thumbnails for both events and for recurring-events, that information does not get copied when recurring events are generated or regenerated.

Is this something that's possible to do? I assume the same thing would apply to other meta information that's added to both events and recurring events, but I don't know that particular detail for sure.

This would be useful in that some organizations use those things (other meta, excerpts, and post thumbnails), and it becomes a manual process to update those after creating a set of events.

I think it would be possible to work around by using the events template to figure out the corresponding recurring-event, then pulling the information from there; however, that's kind of a duct-taped solution.

The name of the taxonomy. Name should only contain lowercase letters and the underscore character, and not be more than 32 characters long (database structure restriction).

Ref. : Function Reference/register_taxonomy

All this info should be filterable - https://github.com/billerickson/BE-Events-Calendar/blob/master/be-events-calendar.php#L80

The https://devpress.com/blog/custom-columns-for-custom-post-types/ link referenced in some docblocks 404s. I believe this is the one you want: http://justintadlock.com/archives/2011/06/27/custom-columns-for-custom-post-types

Code itself is rather clean already from some previous update commits, however the docblocks need just a bit of polish.

Really just need to add @since 1.0.0 to existing functions and make sure any @params used are documented - small stuff.

WordPress 4.6 now specifies datepicker defaults using wp_add_inline_script() for localization (see here).

Problem

The date format they used ("MM d, yy") is different than the jquery-ui-datepicker default format ("mm/dd/yy"). We didn't specifically define a date format, expecting the default to be used.

This causes the following issues:

1. The correct month/year isn't shown when you open the date picker on a field with an already-specified date
   
2. When you select a date using the datepicker, it uses the wrong format

Solution

We need to manually define the format we want, rather than depending upon the default setting.

The recurring_event post type is used to create event posts based based on recursion settings. I think there's no reason to have a recurring_event public. Visitors should only see events.

The downside of that change would be that plugins based on public value like Yoast SEO will not behave the same way.

What are your opinions @billerickson?

See http://keepachangelog.com/

I think a location information is often needed with an event. This could be added as a custom taxonomy and displayed depending on theme support.

Term title and description could be enough for a first implementation.
Term metas could be added later to support coordinates or an URL.

What are your opinions on this @billerickson?
Would you accept a PR?

Add "All Day" toggle to Date/Time regular events metabox that hides time when checked.

I wonder why post thumbnails for events are not supported.

Are we supposed to add it from the theme or a custom plugin with add_post_type_support( 'events', 'thumbnail' ); or should the plugin support post thumbnails by default?

Hey Bill! Awesome plugin and I'm finally getting around to using it on a project. I'm running into an issue that I can't seem to fix.

On Posts and CPT (I have a Podcast CPT), the Event Schema is being added to the article entry

itemtype="http://schema.org/Event"

The main content area is still showing

itemtype="http://schema.org/Blog"

itemType="http://schema.org/BlogPosting"

I saw in genesis-schema.php that it should only run on archives and single events, but for some reason it's showing on others.

Have you run into this issue?

Please add tags to release commits, so they can be pulled down - thanks!

When I generate events from a recurring event the created events start/end dates are all the same (ie. it’s not incrementing be_event_start and be_event_end)

Reviewing the code it seems like this:
recurring-events.php:284
foreach( $metas as $meta )
update_post_meta( $event_id, $meta, get_post_meta( $post_id, $meta, true ) );

is supposed to do that…

This code seems slick to potentially update all post meta, but at least as best I can tell isn't working so I've commented it out and added:

update_post_meta( $event_id, 'be_event_start', $event_start );
update_post_meta( $event_id, 'be_event_end', $event_end );

PR coming....

Going to tidy things up slightly as far as where things are arranged, to keep a cleaner directory when more files/features are added.

Hi Bill,

First off, thanks for this plugin! I really appreciate it!

I noticed that you guys may be combining the Recurring Events and Events posts types soon so this might not be super useful but I added support for mapping the featured image from a recurring event to each individual event that is created and wanted to share it with you or others who may need this functionality.

Also wanted to run it by you in case there are any things that I may have overlooked with this. I have a working but far from intimate understanding of this stuff. :-)

Line 100 - add 'thumbnail' to supports for register_post_type()
Line 411 - set $event_thumb_id variable
Line 438 - mapping thumbnail to event

https://gist.github.com/hirejordansmith/3a78a357c0c4a72f2f2c183501bae26c

It would be great to internationalize the plugin and to support translations.

I will certainly make a PR.

Ideally, there should be some filters to customize the date and time formats.

Using PHP to build out a calendar view is a pain in the ass.

I want to create a shortcode that generates a nice calendar view and leverages http://fullcalendar.io/.

Shortcode should include basic optional params to toggle some of the fullcalendar settings etc. Fullcalendar assets shouldn't load unless shortcode is present and all the proper stuff.

Ideally also add ajax support from going/prev next months. Also if we can get fullcalendar to render decent at a smaller size then should create a widget version of this well.

If you can think of any other items/features to add to this component let me know.

c74e281

http://cl.ly/image/2U3g0W440x1V

This feature should be working well, however in its current iteration there is one down side: right now events only show up on the day they start. So if it is a 3 day festival running from Friday-Sunday on the calendar only Friday will be highlighted and listed. So that needs to be fixed, other than that I think it is solid.

A little follow up to #10, I've got a branch that seems to be working so far. I'm going to circle back to this in a few weeks to test further and refine a few things, but I think this first go at it solves some of the issues with a single post type.

Next up is some conditional recurring options: I think all "children" events in a series should provide the following options. If one of the "update" options is selected, the event details become editable again in the correct context.

• Keep event details as-is (default)
• Update event details and remove from series (similar to this, creates a stand-alone event)
• Update event details for all future events (create a new series with the current post as the series master, optionally deleting all the original series future events or creating a spin-off series and leaving the original series alone)
• Delete all future events in this series. (when trashing or updating the current post, all future events are deleted)

On a previous project I added an option to delete all related recurring events when series master is delete (what happens when a series master is deleted, do we remove the series information from the child events or delete them as well?). Perhaps this is an argument for using a unique id for tracking a series instead of a master post? Or, by default we remove the parent id from all the children, making them stand-alone events?

Firstly, this is an excellent events calendar library. Thanks for sharing it :)

I did find that the activation hook does not fire though. It also doesn't flush the permalinks correctly, as the post-type hasn't loaded before the flushing occurs. You can fix the second issue by directly firing the post type method from within the activation method.

https://github.com/billerickson/BE-Events-Calendar/blob/master/inc/events.php

Instead of using an action hook on get_text, the post type title placeholder should be customized using a filter on enter_title_here.

Hi Bill,

I have a question for you. I am in the process of setting up a front facing event submission form. Everything is working great except the date & time values are not mapping. I believe this is because GF has either a Date or a Time field but not a DateTime field and you are pulling the Date & Time as a single value.

My original idea was to seperate out the Date & Time fields via ACF Pro then map them that way with GF but it appears the Time field would then be null since you have it setup to pull as a single value and the date fields don't map either for the same reason.

As a side item, I was also unable to get the default meta box override to actually override with the following code in functions.php. It still outputs as normal.

add_filter( 'be_events_manager_metabox_override', '__return_true' );

Any thoughts on this? I know you're super busy man, just thought I'd reach out to see if you had a quick solution for this already.

My brother David is a Gravity Forms guru so I also reached out to him to see if he had a possible solution for this. Thanks in advance!

Error message: Warning: date() expects parameter 2 to be integer, string given.

After First Event title, there's an unwanted <.

Events are not prepended with front base, we should be consistent with rewrite args.

$before_widget, $after_widget, $before_title and $after_titleare undefined.

They are located in widget(), the function that outputs the HTML of the widget.