Comments (3)
Taking a look at the implementation, I agree this could use some improvements. The bundle extension probably ought to just pass through nil rather than using IUOs. Then the main initializer could guard on the model instantiation, and as you say it could return an error if the model or the store URL fails.
Though constructing with an invalid model name seems initially to me like a programmer error rather than an expected or "normal" error.
from coredatastack.
Yes this should have been a preconditionFailure
rather than a force unwrap so that you have a proper message in the console output.
Since this type of error is programmer error rather than a recoverable error, I would prefer not to throw
.
from coredatastack.
Included in https://github.com/bignerdranch/CoreDataStack/releases/tag/v1.1.2
from coredatastack.
Related Issues (20)
- Can't run app in simulator with BNRCoreDataStack in Objective-C project, LaunchServicesError HOT 1
- Build issues with Xcode 8 beta 3 HOT 4
- Creating CoreDataStack without dispatching HOT 2
- When using Mogenerator, making a ManagedObject implement CoreDataModelable gives error HOT 6
- NSPersistentStoreCoordinator options. HOT 5
- (Swift 3) Make `performAndWaitOrThrow` `rethrows` and `@noescape` HOT 1
- Issue compiling project with BNRCoreDataStack using Xcode 8 - Swift 2.3 HOT 1
- Publish Pod version 2.0.0 HOT 1
- performAndWaitOrThrow not accessible HOT 5
- Linker issue HOT 2
- Linker issue HOT 5
- Entity name check should not fail because of module name HOT 5
- BNRCOredatastack 1.3.0 issue in xcode 8.2 unable to install on device
- Question: is `.findFirstInContext(...)` not available any more on iOS < 10? HOT 3
- Support programatically created object models HOT 2
- Carthage validation script fails for forks
- Use withoutActuallyEscaping for helpers on Swift 3.1 HOT 5
- How can i use CoreDataStack in an Objective-C project HOT 1
- Xcode 9 support HOT 1
- crash on update of app from app store HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coredatastack.