Giter Club home page Giter Club logo

Comments (5)

rcedwards avatar rcedwards commented on July 24, 2024

Glad to hear you're enjoying the framework.

I'd be open to a PR that expands setupSQLiteBackedCoordinator to accept an optional parameter of store options with a default value of nil (i.e. storeOptions: [NSObject: AnyObject]? = nil).

Then add that parameter to the 3 functions in CoreDataStack that call setupSQLiteBackedCoordinator.

newBatchOperationContext...
constructSQLiteStack...
resetStore...

from coredatastack.

Aranoledur avatar Aranoledur commented on July 24, 2024

Glad you have appreciated this change.

I have made two PR for swift 2.3 and swift 3.0. I decided to make this parameter optional, but default value is stockSQLiteStoreOptions, because if user want to set nil parameters, better to give him this opportunity.

Will be happy if you check PRs.

from coredatastack.

rcedwards avatar rcedwards commented on July 24, 2024

Terrific thanks. It may take us a few days to get our Swift 2.3/Swift 3.0 branches pushed along so bear with us on these PRs.

from coredatastack.

rcedwards avatar rcedwards commented on July 24, 2024

@Aranoledur sorry again for the delay on getting 2.3 and 3.0 pushed out. If this issue is something you'd still like to pursue, please feel free to open PRs against master for Swift 3.0 and swift/2.3 for Swift 2.3. Thanks again

from coredatastack.

Aranoledur avatar Aranoledur commented on July 24, 2024

Hi! Thanks for not forgetting about me.
PR for swift 2.3 #177
In swift 3.0 CoreDataStack is deprecated, so there is no need in this functionality.

from coredatastack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.