Describe the bug
The note count on Hard guitar for You've Got Another Thing Comin' from the current GH2 DLC rips is incorrect.

To Reproduce

1. Set up a song with this mid: notes.zip
2. Play it on Hard guitar
3. Display the note total with ExtraSongUI
4. Observe it says 805 notes

Expected behavior
It should be 803 notes, as it says when you finish the song or FC it.

Environment:

• OS: Windows 10
• Clone Hero Version v0.23.2.2
• Using the new Clone Hero Launcher [no]
• Tweak version v1.4.0.23

The current implementation of the restart functionality is simply loading the Gameplay scene again. This is similar to how v0.20 performed it, but not v0.23. If there are extra things happening, those should be preserved. Alternatively, invoking that restart method is probably the more versatile solution.

Describe the bug
When playing a song that contains star power phrases that have no notes attached, the total number of star powers represented in Extra Song UI's total star powers counter appears to count that number rather than the actual number that can be played.

To Reproduce
Steps to reproduce the behavior:

1. Play Rock Band 1's Are You Gonna Be My Girl on expert guitar.
2. The SP total counter should say 17, but only 15 are playable in the song.
3. The end of song screen should correctly say 15/15 though if you FC.

Expected behavior
For this song in particular, there should be 15 star power phrases, as seen on the end of song screen, so the total counter should say 15.

Environment (please complete the following information):

• OS: Windows
• Clone Hero Version: v0.23.2.2
• Using the new Clone Hero Launcher: no
• Tweak version: v1.2.0.13

Currently the text rendered in gameplay is using IMGUI, which renders on top of all of the scene (including the pause menu). Correctly rendering this with simple text labels should have it appear properly in the scene, and possibly (unproven) improve performance.

Currently, every config file is developed separately. There is a significant amount of redundancy within each one, particularly with how customisable text elements can be modified. Making them more generalised will help me in the future, and reduce the possibility of bugs.

Current progress:

• Accuracy Indicator
• Combo Indicator (doesn't use one)
• Extra Song UI
• Perfect Mode

Currently, only player one is detected. If other players exist, the ability to detect them should work as well.

Basically play the GH3 sound when the indicator appears. Should be nice and easy given the ability to play a sound.

Currently the text rendered in gameplay is using IMGUI, which renders on top of all of the scene (including the pause menu). Correctly rendering this with simple text labels should have it appear properly in the scene, and possibly (unproven) improve performance.

Currently the text rendered in gameplay is using IMGUI, which renders on top of all of the scene (including the pause menu). Correctly rendering this with simple text labels should have it appear properly in the scene, and possibly (unproven) improve performance.

(this might be possible in Common)

Describe the bug
So when I download all the mods on bepinex Including LegacyModLoader run the command and play the game none of the mods work and i cant hit any of the notes

Steps to reproduce the behavior:

1. Download All Mods & Some Tweaks Like GC Fretedit etc.
2. Launch the game when all mods are in Bepinex/plugins And all tweaks are in the Tweaks folder directory
3. Play Any Chart
4. Try To Hit Notes And See You Cant

Expected behavior
IDK

Environment (please complete the following information):

• OS: macOS
• Clone Hero Version: v23.2.2
• Using the new Clone Hero Launcher: No
• Tweak version: v1.5.1

Additional context
None

(this will involve maybe manually injecting something into the score add method)

Several users who install any of the tweaks do not know how to utilise them when they first run the program.

The proposed solution is to store a value in the configs for all the tweaks that notes the last version of the tweak that was run, with the default being null. If the last version in the config does not match the current version of the tweak, the changelog and instructions should appear.

The changelog doesn't have to be massive, but it should indicate new end user features from the previous version.

The instructions should be at least enough to show the user how to enable the config window, how to perform some basic operations, and how to get help.

The window should also be available via a button near the bottom of the config window.

For Combo Indicator, a config will have to be made in order to remember whether the user has run the program for the first time.

Several users have reported having bugs, only to then realise that they weren't running the newest version of the tweaks.

The solution is to add a "Check for Update" button to each of the tweak's config windows. When that button is clicked, the game should search to see that the latest version is being used. This may require a few extra variables to exist with tweaks (e.g. storing the intended game version), but it should be alright.

The version list can easily be gotten by polling a text file on the master branch on Github. It should basically be a mapping between CH version and highest version of the tweaks. Since all tweaks have the same versioning, this file can be pulled out into the root of the repository.

Perfect Mode may need additional work since it currently doesn't have a config window.

(this might be possible in Common)

A user suggested feature, just a way to see that average accuracy at the end result screen.

A proposed solution would simply calculate this value at the end as well using the same numbers used for the categories.

Currently the combo indicator is covered by the solo box when using a 1080p screen. This needs to be remedied.

Currently, only player one is detected. If other players exist, the ability to detect them should work as well.

Currently, only the band streak is detected. That seems to work alright though, so this may not necessarily be an issue.

Currently, only the first player's notes are detected, so it only resets on them. Extra care should be taken in case this breaks online sessions.

Hi Biendo, when adjusting the alignment of the labels every label apart from time is moved by where the : is, but time is moved based on where T is.

Certain observers may notice that the code is very dense within the Unity functions, and could definitely be structured a bit nicer. Without tweaking the functionality of the code, this should be fixed up before the tweaks scale larger.

Some users have reported the end of song screen reporting every note as Very Late.

Some specific testing has showed that the times used by the calculations are sometimes in milliseconds as opposed to seconds, which explains why they are all very late. However, it is not clear why this is happening.

A possible (but unproposed) solution would be to detect any notes above 0.07, and divide them by 1000. It probably fixes the problem but it seems like a patch over something broken to begin with, and is not very recommended.

If the user ever hides the mouse cursor in Clone Hero, the cursor is not visible whenever they try to open up a config window, making it very difficult to use the menus.

The proposed solution is to detect whether the mouse was visible or not when the window is opened, and the set its visibility to true. Then, when the window is closed, if the mouse should be invisible, it will be set to that (otherwise ignore setting it). This has the unavoidable side effect of any sequential config windows from other tweaks will not try and hide the mouse when they're closed, even if they're the last ones to be closed. Also the first config window to open will hide the cursor when closed regardless. However, these are easily remedied by the fact that closing and reopening any config window will correct the problem, which is a more usable state than before.

Describe the bug
The average accuracy indicator always shows the same time as the accuracy time indicator.

To Reproduce
Steps to reproduce the behavior:

1. Enable average accuracy indicator
2. Play any song
3. Observe that both indicators show the same number unless the note was missed, in which case the average will show the accuracy of the last hit note.

Expected behavior
Average indicator should actually be an average of all hit notes. Here is an example of lua code that does this

Accumulative = 0
Total = 0
Average = 0
N = 0

function DoAverage(current) --this is the code you want, the rest is just to use it.
    Total = Total + 1
    Accumulative = Accumulative + current
    Average = Accumulative / Total
end

while N < 1000 do --This is just to make it do something
    N = N + 10
    DoAverage(N)
    io.write(Accumulative .. " / " .. Total .. " = " .. Average .. "\n")
end

Environment (please complete the following information):

• OS: Windows 10
• Clone Hero Version: 0.23.2.2
• Using the new Clone Hero Launcher: No
• Tweak version: 1.5.1.88

Additional context
I am NOT using CHLoader, if that matters.

It would be nice to have Extra Song UI show two more values of data during gameplay:

• The current amount of Star Power you have as a value.
  • This could be represented as a percentage where 0% is no star power and 100% is full star power (with 50% being the activation cutoff).
• The current percentage of notes hit.
  • This can simply be a calculation of notes hits divided by notes passed.
  • One quirk is that you will always get 0 divided by 0 before the first note, which typically should give NaN%. Perhaps this should be changed to 100%, and any other possible 0/0 scenarios should be changed too.
• The current percentage through the song.
  • Again nice and simple based on the current progress divided by the total song length (although it will try and surpass 100% at the very end of the song so maybe cap that).

TO BE DETERMINED

Currently there is no customisation available for the combo indicator. This can be something simple such as text size, colour, and position (like what is is Common right now).